New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDB checks should not be done for terminal pods while evicting #68892

Merged
merged 1 commit into from Sep 27, 2018

Conversation

@ravisantoshgudimetla
Contributor

ravisantoshgudimetla commented Sep 20, 2018

Signed-off-by: ravisantoshgudimetla ravisantoshgudimetla@gmail.com

What this PR does / why we need it:
As of now, while evicting terminal pods, we are checking pod disruption budgets for them where as we don't need to check pdbs for them as they already have caused disruption.
/cc @derekwaynecarr

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Pod disruption budgets shouldn't be checked for terminal pods while evicting
PDB checks should not be done for terminal pods while evicting
Signed-off-by: ravisantoshgudimetla <ravisantoshgudimetla@gmail.com>
@ravisantoshgudimetla

This comment has been minimized.

Show comment
Hide comment
@ravisantoshgudimetla

ravisantoshgudimetla Sep 20, 2018

Contributor

/sig scheduling
/sig api-server

Contributor

ravisantoshgudimetla commented Sep 20, 2018

/sig scheduling
/sig api-server

@ravisantoshgudimetla

This comment has been minimized.

Show comment
Hide comment
@ravisantoshgudimetla

ravisantoshgudimetla Sep 20, 2018

Contributor

/kind bug

Contributor

ravisantoshgudimetla commented Sep 20, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug and removed needs-kind labels Sep 20, 2018

@ravisantoshgudimetla

This comment has been minimized.

Show comment
Hide comment
@ravisantoshgudimetla

ravisantoshgudimetla Sep 20, 2018

Contributor

/priority critical-urgent

Contributor

ravisantoshgudimetla commented Sep 20, 2018

/priority critical-urgent

@derekwaynecarr

This comment has been minimized.

Show comment
Hide comment
@derekwaynecarr

derekwaynecarr Sep 20, 2018

Member

@ravisantoshgudimetla thank you for following up on this!

/lgtm

Member

derekwaynecarr commented Sep 20, 2018

@ravisantoshgudimetla thank you for following up on this!

/lgtm

@deads2k

This comment has been minimized.

Show comment
Hide comment
@deads2k

deads2k Sep 20, 2018

Contributor

/approve

This can prevent draining, but I don't think it is a regression (@ravisantoshgudimetla correct me if I'm mistaken). We should backport for 1.12.1.

Contributor

deads2k commented Sep 20, 2018

/approve

This can prevent draining, but I don't think it is a regression (@ravisantoshgudimetla correct me if I'm mistaken). We should backport for 1.12.1.

@bsalamat

I am fine with this change. We must also ensure that the caller which requests the eviction checks the status of the pod and not request it for terminated pods.

/lgtm

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 20, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, deads2k, derekwaynecarr, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, deads2k, derekwaynecarr, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3d2fcf4 into kubernetes:master Sep 27, 2018

18 checks passed

cla/linuxfoundation ravisantoshgudimetla authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@ravisantoshgudimetla ravisantoshgudimetla deleted the ravisantoshgudimetla:fix-pdb branch Sep 27, 2018

k8s-ci-robot added a commit that referenced this pull request Oct 5, 2018

Merge pull request #69378 from ravisantoshgudimetla/automated-cherry-…
…pick-of-#68892-upstream-release-1.12

PDB checks should not be done for terminal pods while evicting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment