Fix for man pages do not build reproducibly #68983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In different distros or environments, we may end up with a different order of the strings printed during help and man page generation, So we should sort so the strings in the man pages is the same everytime. Change-Id: Id8fcbd89336aad8d709ba3adac4b29c808d97ebe
k8s-ci-robot
added
release-note-none
|
/kind bug |
k8s-ci-robot
added
kind/bug
|
still had a diff: \fB\-o\fP, \fB\-\-output\fP="yaml"
- Output format. One of: json|yaml|name|templatefile|template|go\-template|go\-template\-file|jsonpath|jsonpath\-file.
+ Output format. One of: json|yaml|name|template|go\-template|go\-template\-file|templatefile|jsonpath|jsonpath\-file.seems to come from |
|
@bmwiedemann can you please paste the whole diff somewhere? Also one of the full man pages too (from your environment) |
|
I had not properly applied the patch - will retest later. |
|
yes! patch works |
|
@dims Thanks! /lgtm |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, juanvallejo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
In different distros or environments, we may end up with a different
order of the strings printed during help and man page generation,
So we should sort so the strings in the man pages is the same everytime.
Change-Id: Id8fcbd89336aad8d709ba3adac4b29c808d97ebe
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #52269
Special notes for your reviewer:
Please see #48710 (comment)
Release note: