New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --show-all #69255

Merged
merged 1 commit into from Jan 24, 2019

Conversation

@Pingan2017
Copy link
Member

Pingan2017 commented Sep 29, 2018

What this PR does / why we need it:
remove show-all, it is deprecated in 1.10
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Remove deprecated args '--show-all'
@Pingan2017

This comment has been minimized.

Copy link
Member Author

Pingan2017 commented Sep 29, 2018

/kind cleanup
/assign @adohe

@Pingan2017

This comment has been minimized.

Copy link
Member Author

Pingan2017 commented Sep 29, 2018

@juanvallejo

This comment has been minimized.

Copy link
Member

juanvallejo commented Oct 3, 2018

/ok-to-test

@juanvallejo

This comment has been minimized.

Copy link
Member

juanvallejo commented Oct 3, 2018

cc @soltysh for approval

@juanvallejo

This comment has been minimized.

Copy link
Member

juanvallejo commented Oct 4, 2018

/retest

@soltysh
Copy link
Contributor

soltysh left a comment

/hold
/lgtm cancel
We can't remove it yet, based on https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-a-flag-or-cli we need to wait until 12 months, so 1.14 at soonest.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 2, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@Pingan2017

This comment has been minimized.

Copy link
Member Author

Pingan2017 commented Jan 3, 2019

/hold cancel

@Pingan2017

This comment has been minimized.

Copy link
Member Author

Pingan2017 commented Jan 3, 2019

/remove-lifecycle stale
/cc @soltysh

@k8s-ci-robot k8s-ci-robot requested a review from soltysh Jan 3, 2019

@soltysh
Copy link
Contributor

soltysh left a comment

Yup, 1.14 is on now
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 24, 2019

@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Jan 24, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Pingan2017, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2cd8825 into kubernetes:master Jan 24, 2019

19 checks passed

cla/linuxfoundation Pingan2017 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment