New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addon-manager to use debian-base:0.3.2. #69315

Merged
merged 1 commit into from Oct 2, 2018

Conversation

@MrHohn
Member

MrHohn commented Oct 1, 2018

What this PR does / why we need it:
/assign @awly @ixdy

This is similar to #67283.

The actual image bump will happen separately.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #68858

Special notes for your reviewer:

Release note:

NONE
@awly

This comment has been minimized.

Contributor

awly commented Oct 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 1, 2018

@@ -15,24 +15,10 @@
IMAGE=staging-k8s.gcr.io/kube-addon-manager
ARCH?=amd64
TEMP_DIR:=$(shell mktemp -d)
VERSION=v8.7
VERSION=v8.8

This comment has been minimized.

@ixdy

ixdy Oct 1, 2018

Member

is there any significance to the major/minor of this version?

This comment has been minimized.

@MrHohn

MrHohn Oct 1, 2018

Member

Not really, I should probably call it v8.7-r1?

@@ -14,6 +14,8 @@
FROM BASEIMAGE
RUN apt-get update && apt-get install -y bash

This comment has been minimized.

@ixdy

ixdy Oct 1, 2018

Member

use clean-install bash instead. (it's a helper script we installed in debian-base which does this and also cleans up the caches afterwards.)

This comment has been minimized.

@MrHohn

MrHohn Oct 1, 2018

Member

Thanks, good to know. Updated now.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 1, 2018

@@ -1,3 +1,6 @@
### Version 8.7-r1 (Mon October 1 2018 Zihong Zheng <zihongz@google.com>)

This comment has been minimized.

@ixdy

ixdy Oct 1, 2018

Member

eh, v8.8 was fine. wasn't sure whether it merited bumping to v9, but I guess not.

This comment has been minimized.

@MrHohn

MrHohn Oct 2, 2018

Member

Ah got it. Reverted to use v8.8.

@ixdy

This comment has been minimized.

Member

ixdy commented Oct 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 2, 2018

@MrHohn

This comment has been minimized.

Member

MrHohn commented Oct 2, 2018

Thanks, adding @mikedanese for approval.
/assign @mikedanese

@mikedanese

This comment has been minimized.

Member

mikedanese commented Oct 2, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awly, ixdy, mikedanese, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MrHohn

This comment has been minimized.

Member

MrHohn commented Oct 2, 2018

/retest

@MrHohn

This comment has been minimized.

Member

MrHohn commented Oct 2, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug and removed needs-kind labels Oct 2, 2018

@fejta-bot

This comment has been minimized.

fejta-bot commented Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit bcb197e into kubernetes:master Oct 2, 2018

18 checks passed

cla/linuxfoundation MrHohn authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@MrHohn MrHohn referenced this pull request Oct 2, 2018

Merged

Bump addon-manager to v8.8 #69337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment