New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark optional CSIDriver fields as really optional. #69331

Merged
merged 1 commit into from Oct 3, 2018

Conversation

@jsafrane
Member

jsafrane commented Oct 2, 2018

What this PR does / why we need it:
CSIDriver has couple of optional fields which don't have omitempty. See the issue below for error message.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes-csi/driver-registrar#57

Release note:

Fixed CSIDriver API object to allow missing fields.

cc @pohly @davidz627 @verult

@jsafrane

This comment has been minimized.

Show comment
Hide comment
@jsafrane

jsafrane Oct 2, 2018

Member

/kind bug
/sig storage

Member

jsafrane commented Oct 2, 2018

/kind bug
/sig storage

@davidz627

This comment has been minimized.

Show comment
Hide comment
@davidz627

davidz627 Oct 2, 2018

Collaborator

/lgtm
/retest

Collaborator

davidz627 commented Oct 2, 2018

/lgtm
/retest

@davidz627

This comment has been minimized.

Show comment
Hide comment
@davidz627

davidz627 Oct 2, 2018

Collaborator

/lgtm cancel

Are there any other types.go files that need to be updated besides this one?

Collaborator

davidz627 commented Oct 2, 2018

/lgtm cancel

Are there any other types.go files that need to be updated besides this one?

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 2, 2018

@jsafrane

This comment has been minimized.

Show comment
Hide comment
@jsafrane

jsafrane Oct 3, 2018

Member

Are there any other types.go files that need to be updated besides this one?

Not for CSI. Everything is in staging/src/csi-api/pkg/apis.

Member

jsafrane commented Oct 3, 2018

Are there any other types.go files that need to be updated besides this one?

Not for CSI. Everything is in staging/src/csi-api/pkg/apis.

@saad-ali

This comment has been minimized.

Show comment
Hide comment
@saad-ali

saad-ali Oct 3, 2018

Member

/lgtm
/approve

Member

saad-ali commented Oct 3, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 3, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saad-ali

This comment has been minimized.

Show comment
Hide comment
@saad-ali

saad-ali Oct 3, 2018

Member

Please cherry pick to 1.12 branch

Member

saad-ali commented Oct 3, 2018

Please cherry pick to 1.12 branch

@k8s-ci-robot k8s-ci-robot merged commit 2e0e168 into kubernetes:master Oct 3, 2018

18 checks passed

cla/linuxfoundation jsafrane authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@jsafrane

This comment has been minimized.

Show comment
Hide comment
@jsafrane

jsafrane Oct 3, 2018

Member

This PR is probably OK, but should PRs here require API approval? @kubernetes/sig-api-machinery-api-reviews

Member

jsafrane commented Oct 3, 2018

This PR is probably OK, but should PRs here require API approval? @kubernetes/sig-api-machinery-api-reviews

@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp Oct 3, 2018

Member

Yes, it should have required API review (but I also think it is fine). I thought @liggitt had set that up with a fancy OWNERs file, did something get moved?

Member

lavalamp commented Oct 3, 2018

Yes, it should have required API review (but I also think it is fine). I thought @liggitt had set that up with a fancy OWNERs file, did something get moved?

k8s-ci-robot added a commit that referenced this pull request Oct 4, 2018

Merge pull request #69393 from jsafrane/automated-cherry-pick-of-#69331
…-upstream-release-1.12

Automated cherry pick of #69331: Mark optional fields as really optional.
@jennybuckley

This comment has been minimized.

Show comment
Hide comment
@jennybuckley
Contributor

jennybuckley commented Oct 4, 2018

/cc @cheftako

@k8s-ci-robot k8s-ci-robot requested a review from cheftako Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment