Experimental support for running kubelet in container #6936
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g.
So far this PR:
It builds; tests are going to be broken.
Next up: make an image that has this kubelet binary and nsenter and test.
Code in this branch works with docker 1.6. Currently, there's a dependency on 1.6 because it switches the mount propogation mode of bind mounts from
One nit that I found: mounts for volumes are not currently cleaned up when the kubelet is run in a container (ie, umount fails with
With that said, I'm curious about how folks feel about some of this code going in so that we can experiment further without carrying the patch. I would want to:
Unit and integration tests still broken; will fix those up next.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.