New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/google/certificate-transparency-go to v1.0.21 #69408

Merged
merged 1 commit into from Oct 4, 2018

Conversation

@cblecker
Member

cblecker commented Oct 3, 2018

What this PR does / why we need it:
Bump github.com/google/certificate-transparency-go to v1.0.21 to pull in google/certificate-transparency-go@37a384c. This fixes a typecheck error on this library.

Release note:

NONE
@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 3, 2018

Member

Fixes this typecheck failure:

2018/10/03 22:56:45 Code for OpenAPI definitions generated
ERROR(windows) vendor/github.com/google/certificate-transparency-go/x509/root_windows.go:112:20: cannot use uintptr(unsafe.Pointer(sslPara)) (value of type uintptr) as syscall.Pointer value in struct literal
exit status 1
!!! Type Check has failed. This may cause cross platform build failures.
!!! Please see https://git.k8s.io/kubernetes/test/typecheck for more information.
Member

cblecker commented Oct 3, 2018

Fixes this typecheck failure:

2018/10/03 22:56:45 Code for OpenAPI definitions generated
ERROR(windows) vendor/github.com/google/certificate-transparency-go/x509/root_windows.go:112:20: cannot use uintptr(unsafe.Pointer(sslPara)) (value of type uintptr) as syscall.Pointer value in struct literal
exit status 1
!!! Type Check has failed. This may cause cross platform build failures.
!!! Please see https://git.k8s.io/kubernetes/test/typecheck for more information.
@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker
Member

cblecker commented Oct 3, 2018

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 3, 2018

Member

/sig release
/kind bug

Member

cblecker commented Oct 3, 2018

/sig release
/kind bug

@BenTheElder

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 3, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 3, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ixdy

This comment has been minimized.

Show comment
Hide comment
@ixdy

ixdy Oct 3, 2018

Member

It looks like this dep was added in #60373 to update cfssl to be compatible with go1.10.
cc @sttts

Member

ixdy commented Oct 3, 2018

It looks like this dep was added in #60373 to update cfssl to be compatible with go1.10.
cc @sttts

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 4, 2018

Member

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-kubemark-e2e-gce-big

Member

cblecker commented Oct 4, 2018

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-kubemark-e2e-gce-big

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 4, 2018

Member

/test pull-kubernetes-integration

Member

cblecker commented Oct 4, 2018

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 0187ed0 into kubernetes:master Oct 4, 2018

18 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment