Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Move each kubectl command to a separate directory #69464
This was referenced
Oct 5, 2018
This is much better organization of the code. Just a question on if we want commands to depend on other commands (or only something like common or util). If we think we don't want inter-command dependencies, then I think we should add a TODO, and fix in another PR. Another idea we might want to think about is if we should create an unexported "internal" directory somewhere to make clear what is exportable.
That is a good question, but the current patterns we have allow this. See how we use wait and delete flags in other commands. We might want to discuss that during next SIG meeting. It's worth discussing before moving further. It'll take us a few more bits to move the bits here and there, but at least this initial batch is done :)
Re-applying the label back, since I've only fixed bazel. I'm also applying the approve based on slack approval from Phil.
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
The full list of commands accepted by this bot can be found here.
The pull request process is described here