New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove kubelet flag '--experimental-fail-swap-on' (deprecated in v1.8) #69552

Merged
merged 1 commit into from Feb 1, 2019

Conversation

@Pingan2017
Copy link
Member

Pingan2017 commented Oct 9, 2018

What this PR does / why we need it:
--experimental-fail-swap-on deprecated in v1.8, since #47181
It's safe to remove this, which conforms with our deprecation policy.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
cc @dims
Release note:

remove kubelet flag '--experimental-fail-swap-on' (deprecated in v1.8)
@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Oct 9, 2018

/ok-to-test
/kind cleanup

@Pingan2017

This comment has been minimized.

Copy link
Member Author

Pingan2017 commented Oct 9, 2018

/assign @Random-Liu

@Pingan2017

This comment has been minimized.

Copy link
Member Author

Pingan2017 commented Oct 9, 2018

/test pull-kubernetes-local-e2e-containerized

1 similar comment
@Pingan2017

This comment has been minimized.

Copy link
Member Author

Pingan2017 commented Oct 10, 2018

/test pull-kubernetes-local-e2e-containerized

@dims

This comment has been minimized.

Copy link
Member

dims commented Oct 10, 2018

/lgtm

@Pingan2017 you can ignore the pull-kubernetes-local-e2e-containerized job as it's not a required job.

@Pingan2017

This comment has been minimized.

Copy link
Member Author

Pingan2017 commented Oct 12, 2018

@dims Thank u.
cc @yujuhong @vishh @Random-Liu could someone take a look?

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Oct 12, 2018

/lgtm

@Pingan2017

This comment has been minimized.

Copy link
Member Author

Pingan2017 commented Oct 16, 2018

@yujuhong Could you help to approve this?

@dims

This comment has been minimized.

Copy link
Member

dims commented Oct 23, 2018

/unassign @dims

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 21, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Jan 31, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Pingan2017, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Pingan2017

This comment has been minimized.

Copy link
Member Author

Pingan2017 commented Feb 1, 2019

/test pull-kubernetes-godeps

@k8s-ci-robot k8s-ci-robot merged commit 6af7d2c into kubernetes:master Feb 1, 2019

19 checks passed

cla/linuxfoundation Pingan2017 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@Pingan2017 Pingan2017 deleted the Pingan2017:remove-experimental-fail-swap-on-flag branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment