New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update two doc.go files under staging/src/k8s.io/apiserver #69667

Open
wants to merge 1 commit into
base: master
from

Conversation

@zhanghoondennisoh

zhanghoondennisoh commented Oct 11, 2018

Signed-off-by: Zhang-hoon Dennis Oh zhanghoondennisoh@gmail.com

What this PR does / why we need it:
update doc.go in:
staging/src/k8s.io/apiserver/pkg/authentication/user
and
staging/src/k8s.io/apiserver/pkg/authorization/path

This is necessary so that if someone wants to import only this package, the import path is not referred to as github.com, but as the k8s.io vanity url.
Ref: https://golang.org/doc/go1.4#canonicalimports

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Only a partial fix for #68231

Special notes for your reviewer:

Release note:

NONE

Update two doc.go files under staging/src/k8s.io/apiserver
Signed-off-by: Zhang-hoon Dennis Oh <zhanghoondennisoh@gmail.com>
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 11, 2018

Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhanghoondennisoh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 11, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhanghoondennisoh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ncdc and sttts Oct 11, 2018

@zhanghoondennisoh

This comment has been minimized.

Show comment
Hide comment
@zhanghoondennisoh

zhanghoondennisoh commented Oct 11, 2018

/kind cleanup

@seriousdevelopers

This comment has been minimized.

Show comment
Hide comment
@seriousdevelopers

seriousdevelopers commented Oct 11, 2018

/cc @nikhita

@k8s-ci-robot k8s-ci-robot requested a review from nikhita Oct 11, 2018

@nikhita

This comment has been minimized.

Show comment
Hide comment
@nikhita

nikhita Oct 11, 2018

Member

@zhanghoondennisoh Thanks for submitting your first PR. Welcome to Kubernetes! :)

/release-note-none
/ok-to-test
/lgtm

/assign @sttts
for approval

Member

nikhita commented Oct 11, 2018

@zhanghoondennisoh Thanks for submitting your first PR. Welcome to Kubernetes! :)

/release-note-none
/ok-to-test
/lgtm

/assign @sttts
for approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment