New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels when conformance/ directory changes #69673

Merged
merged 1 commit into from Oct 13, 2018

Conversation

Projects
None yet
3 participants
@dims
Member

dims commented Oct 11, 2018

What this PR does / why we need it:

So we don't have to do this manually for every PR

Change-Id: I4dc656e84ff6c48bc582b2aee6615bef11553257

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE
Add labels when conformance/ directory changes
So we don't have to do this manually for every PR

Change-Id: I4dc656e84ff6c48bc582b2aee6615bef11553257
@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Oct 11, 2018

Member

/kind cleanup

Member

dims commented Oct 11, 2018

/kind cleanup

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Oct 11, 2018

Member

/test pull-kubernetes-integration

Member

dims commented Oct 11, 2018

/test pull-kubernetes-integration

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Oct 12, 2018

Member

@justinclayton @bgrant0607 really easy one, just adding labels to OWNERS file. please take a look

Member

dims commented Oct 12, 2018

@justinclayton @bgrant0607 really easy one, just adding labels to OWNERS file. please take a look

@bgrant0607

This comment has been minimized.

Show comment
Hide comment
@bgrant0607

bgrant0607 Oct 13, 2018

Member

Thanks
/lgtm
/approve

Member

bgrant0607 commented Oct 13, 2018

Thanks
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 13, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 13, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Oct 13, 2018

Member

/retest

Member

dims commented Oct 13, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1ba5643 into kubernetes:master Oct 13, 2018

18 checks passed

cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment