New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in the test comments #69674

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
4 participants
@mooncak
Contributor

mooncak commented Oct 11, 2018

Signed-off-by: mooncake xcoder@tenxcloud.com

What this PR does / why we need it:
Fix typos in the test comments:

  1. test/e2e/common/container_probe.go
  2. test/e2e/framework/framework.go
  3. test/e2e/framework/statefulset_utils.go
  4. test/e2e/framework/testfiles/testfiles.go

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE
Fix typos in the test comments
Signed-off-by: mooncake <xcoder@tenxcloud.com>
@mooncak

This comment has been minimized.

Show comment
Hide comment
@mooncak

mooncak Oct 11, 2018

Contributor

/assign @MrHohn

Contributor

mooncak commented Oct 11, 2018

/assign @MrHohn

@wgliang

This comment has been minimized.

Show comment
Hide comment
@wgliang

wgliang Oct 11, 2018

Member

/ok-to-test
/kind cleanup

Member

wgliang commented Oct 11, 2018

/ok-to-test
/kind cleanup

@mooncak

This comment has been minimized.

Show comment
Hide comment
@mooncak

mooncak Oct 11, 2018

Contributor

/test pull-kubernetes-e2e-kops-aws

Contributor

mooncak commented Oct 11, 2018

/test pull-kubernetes-e2e-kops-aws

@MrHohn

MrHohn approved these changes Oct 11, 2018

lgtm

@MrHohn

This comment has been minimized.

Show comment
Hide comment
@MrHohn

MrHohn Oct 11, 2018

Member

/lgtm

Member

MrHohn commented Oct 11, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 11, 2018

@mooncak

This comment has been minimized.

Show comment
Hide comment
@mooncak

mooncak Oct 12, 2018

Contributor

/approve

Contributor

mooncak commented Oct 12, 2018

/approve

@MrHohn

This comment has been minimized.

Show comment
Hide comment
@MrHohn

MrHohn Oct 12, 2018

Member

/approve

Member

MrHohn commented Oct 12, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 12, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mooncak, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mooncak, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a8c76d4 into kubernetes:master Oct 12, 2018

18 checks passed

cla/linuxfoundation mooncak authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment