New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promoted replication controller releasing no longer label matched pod test to conformance test #69675

Open
wants to merge 1 commit into
base: master
from

Conversation

@pontiyaraja

pontiyaraja commented Oct 11, 2018

What this PR does / why we need it:
[Replication controller] releasing/removing the pods which is no longer matched with the created label. Promoting this e2e test to conformance test.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
No flaky
Release note:

NONE

/area test
/sig rc
/sig testing
/sig architecture

/release-note-none

cc @spiffxp

/assign @bgrant0607 @janetkuo

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 11, 2018

Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Oct 11, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot requested review from bgrant0607 and foxish Oct 11, 2018

@pontiyaraja pontiyaraja changed the title from promoted replication controller releasing no longer label matched pods test to conformance test to promoted replication controller releasing no longer label matched pod test to conformance test Oct 11, 2018

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Oct 11, 2018

Member

/needs-ok-to-test
/kind cleanup

Member

spiffxp commented Oct 11, 2018

/needs-ok-to-test
/kind cleanup

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Oct 11, 2018

Member

/ok-to-test

Member

spiffxp commented Oct 11, 2018

/ok-to-test

@pontiyaraja

This comment has been minimized.

Show comment
Hide comment
@pontiyaraja

pontiyaraja commented Oct 11, 2018

/cla-check

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Oct 11, 2018

Member

/check-cla

Member

spiffxp commented Oct 11, 2018

/check-cla

@pontiyaraja

This comment has been minimized.

Show comment
Hide comment
@pontiyaraja

pontiyaraja commented Oct 11, 2018

/check-cla

@pontiyaraja

This comment has been minimized.

Show comment
Hide comment
@pontiyaraja

pontiyaraja commented Oct 11, 2018

/retest

@pontiyaraja

This comment has been minimized.

Show comment
Hide comment
@pontiyaraja

pontiyaraja commented Oct 12, 2018

/check-cla

@spiffxp

Note that I'd rather we not focus on workload API's right now. That said, this looks like a valid conformance test to me, relying on nothing special. Update the description and assuming this isn't flaky I'll /lgtm

Show resolved Hide resolved test/e2e/apps/rc.go
@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Oct 13, 2018

Member

/remove-area test
/area conformance

Member

spiffxp commented Oct 13, 2018

/remove-area test
/area conformance

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Oct 13, 2018

Member

/unassign @bgrant0607
not ready for approval yet

Member

spiffxp commented Oct 13, 2018

/unassign @bgrant0607
not ready for approval yet

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 13, 2018

Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Oct 13, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 13, 2018

Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pontiyaraja
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bgrant0607

If they are not already assigned, you can assign the PR to them by writing /assign @bgrant0607 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 13, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pontiyaraja
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bgrant0607

If they are not already assigned, you can assign the PR to them by writing /assign @bgrant0607 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pontiyaraja

This comment has been minimized.

Show comment
Hide comment
@pontiyaraja

pontiyaraja commented Oct 15, 2018

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Oct 15, 2018

Member

sorry, last request before I /lgtm, can you squash down into a single commit please

Member

spiffxp commented Oct 15, 2018

sorry, last request before I /lgtm, can you squash down into a single commit please

@pontiyaraja

This comment has been minimized.

Show comment
Hide comment
@pontiyaraja

pontiyaraja Oct 16, 2018

@spiffxp squashed down to a single commit

pontiyaraja commented Oct 16, 2018

@spiffxp squashed down to a single commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment