New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary time type #69677

Open
wants to merge 1 commit into
base: master
from

Conversation

@knightXun
Contributor

knightXun commented Oct 11, 2018

What this PR does / why we need it:
remove unnecessary time type, improve volume_manager.go

remove unnecessary time type
remove unnecessary time type, improve volume_manager.go
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 11, 2018

Contributor

@knightXun: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Oct 11, 2018

@knightXun: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wgliang

This comment has been minimized.

Show comment
Hide comment
@wgliang

wgliang Oct 11, 2018

Member

/ok-to-test
/kind cleanup

Member

wgliang commented Oct 11, 2018

/ok-to-test
/kind cleanup

@knightXun

This comment has been minimized.

Show comment
Hide comment
@knightXun

knightXun Oct 12, 2018

Contributor

@wgliang i think it's ok to merge

Contributor

knightXun commented Oct 12, 2018

@wgliang i think it's ok to merge

@wgliang

This comment has been minimized.

Show comment
Hide comment
@wgliang

wgliang Oct 12, 2018

Member

/lgtm

Member

wgliang commented Oct 12, 2018

/lgtm

@knightXun

This comment has been minimized.

Show comment
Hide comment
@knightXun

knightXun Oct 12, 2018

Contributor

ping @saad-ali

Contributor

knightXun commented Oct 12, 2018

ping @saad-ali

@nikhita

This comment has been minimized.

Show comment
Hide comment
@nikhita

nikhita Oct 14, 2018

Member

/assign @saad-ali
for approval

Member

nikhita commented Oct 14, 2018

/assign @saad-ali
for approval

@saad-ali

This comment has been minimized.

Show comment
Hide comment
@saad-ali

saad-ali Oct 15, 2018

Member

/approve

Member

saad-ali commented Oct 15, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 15, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knightXun, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knightXun, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment