New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes golint in test/utils/image #69680

Open
wants to merge 1 commit into
base: master
from

Conversation

@jonfriesen
Contributor

jonfriesen commented Oct 11, 2018

What this PR does / why we need it:
This change fixes the test/utils/image package golint errors.

Which issue(s) this PR fixes:
refer #68026

Special notes for your reviewer:
I renamed ImageConfig to Config to fix stuttering (eg. image.ImageConfig). I couldn't find a spot where this would break other packages. Though I'm not exactly sure what the best practice is on renaming a public struct. Guidance would be appreciated :)

Release note:

NONE
@jonfriesen

This comment has been minimized.

Show comment
Hide comment
@jonfriesen

jonfriesen Oct 11, 2018

Contributor

I messed up the last PR pretty bad, so this is a correctly rebased version of my changes. Sorry about that.

/assign @mkumatag
/assign @ixdy

Contributor

jonfriesen commented Oct 11, 2018

I messed up the last PR pretty bad, so this is a correctly rebased version of my changes. Sorry about that.

/assign @mkumatag
/assign @ixdy

@jonfriesen

This comment has been minimized.

Show comment
Hide comment
@jonfriesen

jonfriesen Oct 17, 2018

Contributor

@ixdy can I please get a /ok-to-test? :)

Contributor

jonfriesen commented Oct 17, 2018

@ixdy can I please get a /ok-to-test? :)

@mkumatag

This comment has been minimized.

Show comment
Hide comment
@mkumatag

mkumatag Oct 17, 2018

Member

/ok-to-test

Member

mkumatag commented Oct 17, 2018

/ok-to-test

@mkumatag

This comment has been minimized.

Show comment
Hide comment
@mkumatag

mkumatag Oct 17, 2018

Member

@jonfriesen oops.. I see a conflict, do you mind resolving it?

Member

mkumatag commented Oct 17, 2018

@jonfriesen oops.. I see a conflict, do you mind resolving it?

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 17, 2018

Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Oct 17, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jonfriesen

This comment has been minimized.

Show comment
Hide comment
@jonfriesen

jonfriesen Oct 17, 2018

Contributor

Hi @mkumatag I rebased my branch off of kubernetes/master and resolved the conflicts and pushed up the changes, now hundreds of commits exist in this PR. Can you advise the appropriate method for brining a PR up to speed?

Contributor

jonfriesen commented Oct 17, 2018

Hi @mkumatag I rebased my branch off of kubernetes/master and resolved the conflicts and pushed up the changes, now hundreds of commits exist in this PR. Can you advise the appropriate method for brining a PR up to speed?

Fixes golint in test/utils/image
This change fixes the test/utils/image package golint errors.

@k8s-ci-robot k8s-ci-robot added size/L and removed size/XXL labels Oct 17, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 17, 2018

Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jonfriesen
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ixdy

If they are not already assigned, you can assign the PR to them by writing /assign @ixdy in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 17, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jonfriesen
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ixdy

If they are not already assigned, you can assign the PR to them by writing /assign @ixdy in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jonfriesen

This comment has been minimized.

Show comment
Hide comment
@jonfriesen

jonfriesen Oct 17, 2018

Contributor

Update, I think I managed to fix it. I accidentally merged after my rebase which caused the additional commits to show up. The branch is now in an appropriate state with resolutions as requested. I'm not sure how to remove all of the additional git tags that the k8s-ci-robot added.

Contributor

jonfriesen commented Oct 17, 2018

Update, I think I managed to fix it. I accidentally merged after my rebase which caused the additional commits to show up. The branch is now in an appropriate state with resolutions as requested. I'm not sure how to remove all of the additional git tags that the k8s-ci-robot added.

@jonfriesen

This comment has been minimized.

Show comment
Hide comment
@jonfriesen

jonfriesen Oct 17, 2018

Contributor

/check-cla
/retest

Contributor

jonfriesen commented Oct 17, 2018

/check-cla
/retest

@jonfriesen

This comment has been minimized.

Show comment
Hide comment
@jonfriesen

jonfriesen Oct 17, 2018

Contributor

/retest

Contributor

jonfriesen commented Oct 17, 2018

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment