New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup pkg/apis/core/types.go #69681

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@knightXun
Contributor

knightXun commented Oct 11, 2018

cleanup pkg/apis/core/types.go

cleanup pkg/apis/core/types.go
cleanup pkg/apis/core/types.go
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 11, 2018

Contributor

@knightXun: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Oct 11, 2018

@knightXun: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 11, 2018

Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knightXun
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: erictune

If they are not already assigned, you can assign the PR to them by writing /assign @erictune in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 11, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knightXun
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: erictune

If they are not already assigned, you can assign the PR to them by writing /assign @erictune in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mcrute

This comment has been minimized.

Show comment
Hide comment
@mcrute

mcrute Oct 18, 2018

Contributor

/remove-kind api-change
/ok-to-test

Contributor

mcrute commented Oct 18, 2018

/remove-kind api-change
/ok-to-test

@mcrute

This comment has been minimized.

Show comment
Hide comment
@mcrute

mcrute Oct 18, 2018

Contributor

/release-note-none

Contributor

mcrute commented Oct 18, 2018

/release-note-none

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 18, 2018

Contributor

@mcrute: Those labels are not set on the issue: kind/api-change

In response to this:

/remove-kind api-change
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Oct 18, 2018

@mcrute: Those labels are not set on the issue: kind/api-change

In response to this:

/remove-kind api-change
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mcrute

This comment has been minimized.

Show comment
Hide comment
@mcrute

mcrute Oct 18, 2018

Contributor

Should be ready to merge... adding @erictune for approval

/assign @erictune

Contributor

mcrute commented Oct 18, 2018

Should be ready to merge... adding @erictune for approval

/assign @erictune

@mcrute

This comment has been minimized.

Show comment
Hide comment
@mcrute

mcrute Oct 18, 2018

Contributor

/lgtm

Contributor

mcrute commented Oct 18, 2018

/lgtm

@knightXun

This comment has been minimized.

Show comment
Hide comment
@knightXun

knightXun Oct 18, 2018

Contributor

@mcrute thx

Contributor

knightXun commented Oct 18, 2018

@mcrute thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment