New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some duplicate code of pkg/kubelet #69682

Open
wants to merge 1 commit into
base: master
from

Conversation

@knightXun
Contributor

knightXun commented Oct 11, 2018

What this PR does / why we need it:

  1. remove unnecessory type indication
  2. put actions of docker in one places

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

None
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 11, 2018

Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knightXun
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tallclair

If they are not already assigned, you can assign the PR to them by writing /assign @tallclair in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 11, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knightXun
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tallclair

If they are not already assigned, you can assign the PR to them by writing /assign @tallclair in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knightXun

This comment has been minimized.

Show comment
Hide comment
@knightXun

knightXun Oct 12, 2018

Contributor

/assign xiangpengzhao

Contributor

knightXun commented Oct 12, 2018

/assign xiangpengzhao

@xiangpengzhao

Basically LGTM. Defer to sig-node folks to confirm.

@xiangpengzhao

This comment has been minimized.

Show comment
Hide comment
@xiangpengzhao

xiangpengzhao Oct 16, 2018

Member

/release-note none
/ok-to-test

Member

xiangpengzhao commented Oct 16, 2018

/release-note none
/ok-to-test

remove some duplicate code of pkg/kubelet
1. remove unnecessory type indication
2. put actions of docker in one places
@xiangpengzhao

This comment has been minimized.

Show comment
Hide comment
@xiangpengzhao

xiangpengzhao Oct 17, 2018

Member

@knightXun Please edit the "Release note:" block as None in the PR body.

Member

xiangpengzhao commented Oct 17, 2018

@knightXun Please edit the "Release note:" block as None in the PR body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment