Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl: move translated data into kubectl #69709

Merged
merged 1 commit into from Oct 18, 2018

Conversation

@seans3
Copy link
Contributor

seans3 commented Oct 11, 2018

  • Moved generated translate binary data into kubectl.
  • Only kubectl depends on this generated translate binary data.
  • Removes a kubectl dependency on Kubernetes core.

NOTE:
The following translation artifacts must be copied into the new kubectl repo before we can build kubectl from the new repo. These include

  • /translations/kubectl/...
  • /translations/extract.py
  • /hack/update-translations.sh
  • /hack/generate-bindata.sh

Helps address:
kubernetes/kubectl#80

NONE
@seans3

This comment has been minimized.

Copy link
Contributor Author

seans3 commented Oct 11, 2018

/kind cleanup
/sig cli
/area kubectl
/assign

@seans3

This comment has been minimized.

Copy link
Contributor Author

seans3 commented Oct 11, 2018

@k8s-ci-robot k8s-ci-robot requested review from juanvallejo and soltysh Oct 11, 2018

@seans3 seans3 changed the title kubectl: move translated data into kubectl [WIP] kubectl: move translated data into kubectl Oct 12, 2018

@juanvallejo

This comment has been minimized.

Copy link
Member

juanvallejo commented Oct 12, 2018

lgtm, looks like you'll need to add the new location of the generated/bindata.go file to golint ignores

@seans3 seans3 force-pushed the seans3:kubectl-translate-fix branch 2 times, most recently from aaf1ab2 to 797691e Oct 12, 2018

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Oct 12, 2018

@seans3 seans3 force-pushed the seans3:kubectl-translate-fix branch 2 times, most recently from 875631a to 141b7d8 Oct 12, 2018

@k8s-ci-robot k8s-ci-robot removed the size/S label Oct 15, 2018

@seans3

This comment has been minimized.

Copy link
Contributor Author

seans3 commented Oct 16, 2018

/retest

@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Oct 16, 2018

You still have the same problem that Juan mentions about updating golint failures.

@seans3 seans3 force-pushed the seans3:kubectl-translate-fix branch from 4055bae to 08d0c82 Oct 16, 2018

@seans3 seans3 changed the title [WIP] kubectl: move translated data into kubectl kubectl: move translated data into kubectl Oct 16, 2018

@seans3 seans3 force-pushed the seans3:kubectl-translate-fix branch from 08d0c82 to 9ed2a42 Oct 16, 2018

@seans3

This comment has been minimized.

Copy link
Contributor Author

seans3 commented Oct 16, 2018

You still have the same problem that Juan mentions about updating golint failures.

Actually, I discovered directories with generated files like bindata.go do not go into the golint_failures file, since they are handled specially by hack/verify-golint.sh. That is why the previous location for bindata.go (pkg/generated), isn't in the golint_failures file. So no need to do anything with golint for this PR.

@seans3 seans3 force-pushed the seans3:kubectl-translate-fix branch from 9ed2a42 to 17924bd Oct 17, 2018

@seans3 seans3 force-pushed the seans3:kubectl-translate-fix branch from 17924bd to b7f8369 Oct 17, 2018

@seans3

This comment has been minimized.

Copy link
Contributor Author

seans3 commented Oct 17, 2018

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@soltysh
Copy link
Contributor

soltysh left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seans3, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4d66eeb into kubernetes:master Oct 18, 2018

18 checks passed

cla/linuxfoundation seans3 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@seans3 seans3 deleted the seans3:kubectl-translate-fix branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.