New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Azure premium file for azure file plugin #69718

Merged
merged 2 commits into from Oct 18, 2018

Conversation

@andyzhangx
Member

andyzhangx commented Oct 12, 2018

What this PR does / why we need it:
support Azure file premium for azure file plugin, this PR includes two commits:

  • upgrade azure-sdk-for-go to 2018-07-01 to support File Storage Account Kind which would supports azure premium file
  • when user create azure file PVC with skuName specified as Premium_LRS in azure file storage class, azure provider will search or create File Storage storage account, and then create azure premium file

Pls note that azure premium file only supports pvc size >= 5GB (100GB in the future), otherwise user will get following error:

Failed to provision volume with StorageClass "azurefile-premium": failed to create share andy-mg1121-dynamic-pvc-1a7b2813-d1b7-11e8-9e96-000d3a03e16b in account f7228f99bcde411e8ba4900: failed to create file share, err: storage: service returned error: StatusCode=400, ErrorCode=InvalidHeaderValue, ErrorMessage=The value for one of the HTTP headers is not in the correct format.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #69265

Special notes for your reviewer:
azure premium file storage class example:

---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: azurefile-premium
provisioner: kubernetes.io/azure-file
parameters:
  skuName: Premium_LRS

Release note:

support Azure premium file for azure file plugin

/kind feature
/sig azure

/assign @feiskyer @khenidak
cc @@brendandburns

upgrade azure go sdk for azure file premium support
update azure sdk for azure file premium support

update azure sdk to support azure file premium

update bazel
@andyzhangx

This comment has been minimized.

Member

andyzhangx commented Oct 12, 2018

/test pull-kubernetes-e2e-gce-100-performance

@feiskyer

This comment has been minimized.

Member

feiskyer commented Oct 15, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 15, 2018

@andyzhangx

This comment has been minimized.

Member

andyzhangx commented Oct 15, 2018

/assign @brendandburns

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 15, 2018

@andyzhangx: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @brendandburns for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedebongio

This comment has been minimized.

Contributor

fedebongio commented Oct 15, 2018

/assign @cheftako

add azure premium file support
update bazel and fix goftm

use defaultStorageAccountKind

fix test failure

update godep license file

fix staging godeps issue

update staging godeps

fix comments, use one API call for file creation

@k8s-ci-robot k8s-ci-robot added size/L and removed lgtm size/M labels Oct 17, 2018

@yastij

yastij approved these changes Oct 17, 2018

/lgtm

@brendandburns

This comment has been minimized.

Contributor

brendandburns commented Oct 18, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

fejta-bot commented Oct 18, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@andyzhangx

This comment has been minimized.

Member

andyzhangx commented Oct 18, 2018

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit b5c2572 into kubernetes:master Oct 18, 2018

18 checks passed

cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment