Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support Azure premium file dynamic provision in azure file plugin #69718

Merged
merged 2 commits into from Oct 18, 2018
Merged

support Azure premium file dynamic provision in azure file plugin #69718

merged 2 commits into from Oct 18, 2018

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Oct 12, 2018 •
edited

What this PR does / why we need it:
support Azure file premium for azure file plugin, this PR includes two commits:

  • upgrade azure-sdk-for-go to 2018-07-01 to support File Storage Account Kind which would supports azure premium file
  • when user create azure file PVC with skuName specified as Premium_LRS in azure file storage class, azure provider will search or create File Storage storage account, and then create azure premium file

Pls note that azure premium file only supports pvc size >= 5GB (100GB in the future), otherwise user will get following error:

Failed to provision volume with StorageClass "azurefile-premium": failed to create share andy-mg1121-dynamic-pvc-1a7b2813-d1b7-11e8-9e96-000d3a03e16b in account f7228f99bcde411e8ba4900: failed to create file share, err: storage: service returned error: StatusCode=400, ErrorCode=InvalidHeaderValue, ErrorMessage=The value for one of the HTTP headers is not in the correct format.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #69265

Special notes for your reviewer:
azure premium file storage class example:

---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: azurefile-premium
provisioner: kubernetes.io/azure-file
parameters:
  skuName: Premium_LRS

Release note:

support Azure premium file for azure file plugin

/kind feature
/sig azure

/assign @feiskyer @khenidak
cc @@brendandburns

@andyzhangx
upgrade azure go sdk for azure file premium support
12284c9 
update azure sdk for azure file premium support

update azure sdk to support azure file premium

update bazel
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 12, 2018
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/azure cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Oct 12, 2018
@andyzhangx andyzhangx force-pushed the azurefile-premium branch 3 times, most recently from ec46b58 to e868484 Compare October 12, 2018 14:34
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 12, 2018
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-gce-100-performance

@feiskyer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2018
@andyzhangx
Copy link
Member Author

andyzhangx commented Oct 15, 2018 •
edited

/assign @brendandburns

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @brendandburns for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedebongio
Copy link
Contributor

/assign @cheftako

@andyzhangx
add azure premium file support
bc2c79a 
update bazel and fix goftm

use defaultStorageAccountKind

fix test failure

update godep license file

fix staging godeps issue

update staging godeps

fix comments, use one API call for file creation
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2018
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2018
yastij
yastij approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2018
feiskyer
feiskyer reviewed Oct 18, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit b5c2572 into kubernetes:master Oct 18, 2018
@andyzhangx andyzhangx mentioned this pull request Dec 4, 2018
Closed
@andyzhangx andyzhangx changed the title support Azure premium file for azure file plugin support Azure premium file dynamic provision in azure file plugin Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@cheftako cheftako cheftako left review comments

@yastij yastij yastij approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@feiskyer feiskyer

@cheftako cheftako

@brendandburns brendandburns

@yastij yastij

@khenidak khenidak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support Azure file premium for azure file plugin
9 participants
@andyzhangx @feiskyer @k8s-ci-robot @fedebongio @brendandburns @fejta-bot @cheftako @yastij @khenidak