Remove flaky test by avoiding reuse of name for replicaset #69739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
sig/testing
|
/test pull-kubernetes-integration |
lavalamp
reviewed
Oct 12, 2018
| @@ -510,11 +510,12 @@ run_rs_tests() { | |||
| # Pre-condition: no replica set exists | |||
| kube::test::get_object_assert rs "{{range.items}}{{$id_field}}:{{end}}" '' | |||
| # Command | |||
| kubectl create -f hack/testdata/frontend-replicaset.yaml "${kube_flags[@]}" | |||
| local replicaset_name="frontend-no-cascade" | |||
| sed -r 's/^(\s*)(name\s*:\s*frontend\s*$)/\1name: '"${replicaset_name}"'/' hack/testdata/frontend-replicaset.yaml | kubectl create "${kube_flags[@]}" -f - | |||
There was a problem hiding this comment.
Add a todo to revert this after the bug is fixed?
mortent
force-pushed
the
UnflakeCmdRsTest
branch
from
53ddf82
to
dcb3d8b
Compare
|
/test pull-kubernetes-integration |
1 similar comment
|
/test pull-kubernetes-integration |
|
/assign @seans3 |
k8s-ci-robot
added
the
lgtm
|
/remove lgtm |
|
/kind failing-test |
k8s-ci-robot
added
kind/failing-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mortent, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
runyontr
added a commit
to runyontr/kubernetes
that referenced
this pull request
Jan 15, 2019
When the ReplicaSet controller fetches a fresh version of the ReplicaSet from the server it validates that the UID of the fresh matches the one in the cache. If the UID does not match, a race condition outlined in the issue must have occurred and the controller should intepret the call to syncReplicaSet as a delete. Reverts the merge that temporarily fixed the bug that would occasionally fail as a result of this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: As reported in #69376, run_rs_tests is flaky and the underlying cause is a problem with ReplicaSets when names are reused. The run_rs_tests actually tests kubectl, so this PR removes the flakiness by avoiding this issue with ReplicaSets. It should fix the flakiness and the issue in ReplicaSet can be fixed separately.
It complicates the test a bit with the use of sed, but it seemed better than using sleep or adding additional test data.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #69376
Special notes for your reviewer:
@kow3ns
Release note: