New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in node tree when all nodes in a zone are removed #69758

Merged
merged 1 commit into from Oct 14, 2018

Conversation

@bsalamat
Contributor

bsalamat commented Oct 13, 2018

What this PR does / why we need it:
Fixes a bug in node-tree of the scheduler when all nodes in a zone are removed while "next" is called in certain order.
This issue happens rarely, but if it happens the scheduler can no longer iterate over nodes and goes to an infinite loop trying to find the next node. The only solution is to restart the scheduler.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #69597

Special notes for your reviewer:

Release note:

Fix a bug in the scheduler that could cause the scheduler to go to an infinite loop when all nodes in a zone are removed.
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 13, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AishSundar

This comment has been minimized.

Contributor

AishSundar commented Oct 13, 2018

@feiskyer FYI that this needs to be CPed into 1.12

@bsalamat

This comment has been minimized.

Contributor

bsalamat commented Oct 13, 2018

/retest

@bsalamat

This comment has been minimized.

Contributor

bsalamat commented Oct 13, 2018

@AishSundar @feiskyer #69759 is the cherrypick

@k82cn

This comment has been minimized.

Member

k82cn commented Oct 14, 2018

/lgtm

@fejta-bot

This comment has been minimized.

fejta-bot commented Oct 14, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

3 similar comments
@fejta-bot

This comment has been minimized.

fejta-bot commented Oct 14, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

fejta-bot commented Oct 14, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

fejta-bot commented Oct 14, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@ravisantoshgudimetla

This comment has been minimized.

Contributor

ravisantoshgudimetla commented Oct 14, 2018

/retest

@ravisantoshgudimetla

Thanks for the fix @bsalamat.

/lgtm

@ravisantoshgudimetla

This comment has been minimized.

Contributor

ravisantoshgudimetla commented Oct 14, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 81c10dd into kubernetes:master Oct 14, 2018

18 checks passed

cla/linuxfoundation bsalamat authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

k8s-ci-robot added a commit that referenced this pull request Oct 15, 2018

Merge pull request #69759 from bsalamat/automated-cherry-pick-of-#69758
…-release-1.12

Fix a bug in node tree when all nodes in a zone are removed

@bsalamat bsalamat deleted the bsalamat:fix_node_tree branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment