Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd2 code cleanup, remove deserialization cache #69842

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
4 participants
@liggitt
Copy link
Member

liggitt commented Oct 16, 2018

What this PR does / why we need it:
finishes cleaning up remnants of etcd2 storage code. removes unused deserialization cache flags/config.

Viewing the diff without whitespace shows the actual changes more clearly.

Release note:

kube-apiserver: the `--deserialization-cache-size` flag is no longer used, is deprecated, and will be removed in a future release

/sig api-machinery
/assign @wojtek-t

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Oct 16, 2018

/kind cleanup

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Oct 16, 2018

Thanks a lot for this @liggitt !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 16, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 21cb721 into kubernetes:master Oct 16, 2018

18 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:etcd2-cleanup branch Oct 16, 2018

@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Oct 18, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 18, 2018

@fedebongio: GitHub didn't allow me to request PR reviews from the following users: wenjiaswe.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @wenjiaswe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.