Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default azure file mount permission to 0777 #69854

Merged
merged 1 commit into from Oct 17, 2018

Conversation

@andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Oct 16, 2018

What this PR does / why we need it:
Default azure file permission 0755 is not suitable for most users, dozens of users complain about this, set as 0777 is the best choice here, if users don't want 0777, then they could use mountOptions to override dir_mode and file_mode.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #69853

Special notes for your reviewer:
I have seen at least 20+ complain about this default permission of 0755, let's set as 0777 by default in all versions.

Release note:

change default azure file mount permission to 0777

/assign @feiskyer
cc @khenidak
/kind bug

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Oct 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from feiskyer and jsafrane Oct 16, 2018
@k8s-ci-robot k8s-ci-robot added sig/storage and removed needs-sig labels Oct 16, 2018
Copy link
Member

@feiskyer feiskyer left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm kind/bug and removed needs-kind labels Oct 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit c585d13 into kubernetes:master Oct 17, 2018
18 checks passed
18 checks passed
cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
k8s-ci-robot added a commit that referenced this pull request Oct 18, 2018
…9854-upstream-release-1.12

Automated cherry pick of #69854: change azure file mount permission to 0777
k8s-ci-robot added a commit that referenced this pull request Oct 19, 2018
…9854-upstream-release-1.11

Automated cherry pick of #69854: change azure file mount permission to 0777
k8s-ci-robot added a commit that referenced this pull request Oct 19, 2018
…9854-upstream-release-1.10

Automated cherry pick of #69854: change azure file mount permission to 0777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.