Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Make CoreDNS default in kubeup and update CoreDNS version/manifest in kubeup and kubeadm #69883
What this PR does / why we need it:
Makes CoreDNS default for kube-up
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
This version of CoreDNS (1.2.4) contains improvements that reduce memory usage at scale. Based on the 500 node and 2000 node e2e scale test results, we have linearly projected that memory use in the 5000 node scale test should be less than the prescribed resource limit. But since the 5000 node scale test is not available as a pre-submit, we cannot confirm until this PR is merged.
referenced this pull request
Oct 16, 2018
Latest commit is intended to run the latest coredns release (1.2.4) through e2e presubmit tests prior to pushing the coredns image to gcr.io. If all is OK, we will kick off the push to gcr.io, and I'll update the image locations in the manifests here (from
yes, the image up.
there have been quite a bit of confusion about this part over the last couple of cycles - "default in what?"
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Oct 19, 2018
18 checks passed
I don't believe we can port the entire change back, i.e. Retroactively making CoreDNS the default cluster DNS for kubeup installations.
But we could push newer default versions/manifests of coredns into kubedns/kubeadm of older versions. I'd think this would be reserved for security fixes and major bug fixes, although I'm not personally familiar with the policy for support on past versions of k8s. Question for the sig-lifecycle team I think?