Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CoreDNS default in kubeup and update CoreDNS version/manifest in kubeup and kubeadm #69883

Merged
merged 1 commit into from Oct 19, 2018

Conversation

@chrisohaver
Copy link
Contributor

chrisohaver commented Oct 16, 2018

What this PR does / why we need it:

Makes CoreDNS default for kube-up
Updates manifest and CoreDNS version for kube-up and kubeadm.

KEP: https://github.com/kubernetes/community/blob/master/keps/sig-network/0012-20180518-coredns-default-proposal.md
Feature: kubernetes/enhancements#566

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

This version of CoreDNS (1.2.4) contains improvements that reduce memory usage at scale. Based on the 500 node and 2000 node e2e scale test results, we have linearly projected that memory use in the 5000 node scale test should be less than the prescribed resource limit. But since the 5000 node scale test is not available as a pre-submit, we cannot confirm until this PR is merged.

Release note:

CoreDNS is now the default DNS server in kube-up deployments. 
@chrisohaver

This comment has been minimized.

Copy link
Contributor Author

chrisohaver commented Oct 16, 2018

/hold until 1.2.3 is pushed to gcr.io (#69880)

@chrisohaver

This comment has been minimized.

Copy link
Contributor Author

chrisohaver commented Oct 16, 2018

/hold

@rajansandeep

This comment has been minimized.

Copy link
Member

rajansandeep commented Oct 16, 2018

/kind feature

@neolit123
Copy link
Member

neolit123 left a comment

@chrisohaver thanks for the update to coredns 1.2.3.
added one minor comment.

resources:
- nodes
verbs:
- get

This comment has been minimized.

Copy link
@neolit123

neolit123 Oct 16, 2018

Member

i'm pretty sure these should be under rules:.
http://people.redhat.com/jrivera/openshift-docs_preview/openshift-online/glusterfs-review/rest_api/apis-rbac.authorization.k8s.io/v1.ClusterRole.html#object-schema

i guess this applies to the rest of the files that are changed from the diff.

This comment has been minimized.

Copy link
@shashidharatd

shashidharatd Oct 17, 2018

Member

@neolit123, they are under rules: as one more list item. Am i missing something here?

This comment has been minimized.

Copy link
@neolit123

neolit123 Oct 17, 2018

Member

never mind, i got confused by the indentation.

@chrisohaver

This comment has been minimized.

Copy link
Contributor Author

chrisohaver commented Oct 17, 2018

We've identified a bug in CoreDNS 1.2.3 that makes it invalid for kubernetes deployment.
Closing this issue. Will re-open, or re-sibmit a new PR with new version when the CoreDNS issue is resolved and new version cut.

@chrisohaver

This comment has been minimized.

Copy link
Contributor Author

chrisohaver commented Oct 18, 2018

Latest commit is intended to run the latest coredns release (1.2.4) through e2e presubmit tests prior to pushing the coredns image to gcr.io. If all is OK, we will kick off the push to gcr.io, and I'll update the image locations in the manifests here (from coredns/coredns to k8s.gcr.io/coredns).

@chrisohaver

This comment has been minimized.

Copy link
Contributor Author

chrisohaver commented Oct 18, 2018

I suspect the e2e test nodes don't have access staging-k8s.gcr.io, hence failure to pull images, and subsequent test failure. Will test now on k8s.gcr.io, since latest version appears to be already promoted.

@chrisohaver chrisohaver force-pushed the chrisohaver:coredns-default branch from d4689f0 to 0cfb4bb Oct 18, 2018

@chrisohaver

This comment has been minimized.

Copy link
Contributor Author

chrisohaver commented Oct 18, 2018

I've squashed the commits. Commit 0cfb4bb is now pointing to the k8s.gcr.io repo.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Oct 18, 2018

Will test now on k8s.gcr.io, since latest version appears to be already promoted.

yes, the image up.

Make CoreDNS default and update version

there have been quite a bit of confusion about this part over the last couple of cycles - "default in what?"
i think the first sentence in the description summarizes it better:

Makes CoreDNS default for kube-up

@chrisohaver chrisohaver changed the title Make CoreDNS default and update version Make CoreDNS default in kubeup and update coredns version/manifest in kubeup and kubeadm Oct 18, 2018

@chrisohaver chrisohaver changed the title Make CoreDNS default in kubeup and update coredns version/manifest in kubeup and kubeadm Make CoreDNS default in kubeup and update CoreDNS version/manifest in kubeup and kubeadm Oct 18, 2018

@chrisohaver

This comment has been minimized.

Copy link
Contributor Author

chrisohaver commented Oct 18, 2018

/test pull-kubernetes-integration

@chrisohaver

This comment has been minimized.

Copy link
Contributor Author

chrisohaver commented Oct 18, 2018

/hold cancel

@chrisohaver

This comment has been minimized.

Copy link
Contributor Author

chrisohaver commented Oct 18, 2018

/test pull-kubernetes-e2e-kops-aws

@chrisohaver

This comment has been minimized.

Copy link
Contributor Author

chrisohaver commented Oct 18, 2018

/assign @bowei @timothysc

@chrisohaver

This comment has been minimized.

Copy link
Contributor Author

chrisohaver commented Oct 18, 2018

/assign @thockin

@fturib

This comment has been minimized.

Copy link
Contributor

fturib commented Oct 18, 2018

/assign @thockin

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Oct 18, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 18, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisohaver, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Oct 18, 2018

@jberkus and @mortent as FYI

@k8s-ci-robot k8s-ci-robot merged commit 52de5c5 into kubernetes:master Oct 19, 2018

18 checks passed

cla/linuxfoundation chrisohaver authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@shashidharatd

This comment has been minimized.

Copy link
Member

shashidharatd commented Oct 22, 2018

How about merging this pr to other release branches? (v1.11 and v1.12). Does this pr qualify to be back ported to previous releases?

@chrisohaver

This comment has been minimized.

Copy link
Contributor Author

chrisohaver commented Oct 22, 2018

How about merging this pr to other release branches? (v1.11 and v1.12). Does this pr qualify to be back ported to previous releases?

I don't believe we can port the entire change back, i.e. Retroactively making CoreDNS the default cluster DNS for kubeup installations.

But we could push newer default versions/manifests of coredns into kubedns/kubeadm of older versions. I'd think this would be reserved for security fixes and major bug fixes, although I'm not personally familiar with the policy for support on past versions of k8s. Question for the sig-lifecycle team I think?

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Oct 22, 2018

How about merging this pr to other release branches? (v1.11 and v1.12). Does this pr qualify to be back ported to previous releases?

nope, not really.

@D-PENG

This comment has been minimized.

Copy link

D-PENG commented Oct 26, 2018

good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.