New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cardinality of admission webhook metrics #69895

Merged
merged 1 commit into from Oct 22, 2018

Conversation

@jpbetz
Contributor

jpbetz commented Oct 16, 2018

Per #69540, including resource related labels on admission webhook labels on large cluster with lots of CRDs incurs unacceptable amounts of memory use and churn.

This PR removes the resource related labels: group, version, resource and subresource.

Reduce memory utilization of admission webhook metrics by removing resource related labels.

/sig api-machinery
/kind cleanup
/cc @smarterclayton

@jpbetz

This comment has been minimized.

Contributor

jpbetz commented Oct 16, 2018

/retest

@jpbetz

This comment has been minimized.

Contributor

jpbetz commented Oct 17, 2018

This is ready for review.

@jpbetz

This comment has been minimized.

Contributor

jpbetz commented Oct 22, 2018

@smarterclayton Friendly ping for review

@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Oct 22, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 22, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 04d3949 into kubernetes:master Oct 22, 2018

18 checks passed

cla/linuxfoundation jpbetz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment