Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
kubeadm: fix config fetch via 'config view' #69969
What type of PR is this?
What this PR does / why we need it:
not a cherry pick as our PRs that implement changes are huge.
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
@neolit123: GitHub didn't allow me to request PR reviews from the following users: rdodev.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@rdodev: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.
I'm not 100% sure this is a safe cherry pick, because kueadm v1.12 must support also v1.11 clusters, where the config map key was called into configuration.
So IMo the backport should be a little bit more sophisticated:e.g. If a old key exist, output old key otherwise output new key
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing