New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian-base: purge libsystemd0 to eliminate CVE false-positives #69995

Merged
merged 2 commits into from Oct 19, 2018

Conversation

@ixdy
Member

ixdy commented Oct 18, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it: we already purge systemd and systemd-sysv from the debian-base container, since we don't use them, but libsystemd0 is still part of the image, which is causing false CVE alerts from the GCR Container Analysis service.

Does this PR introduce a user-facing change?:

Images based on debian-base no longer include the libsystemd0 package. This should have no user-facing impact.
Additionally, the addon-manager image is updated to use kubectl v1.11.3.

I don't expect this change to have any user-facing changes. We'll need to be more cautious once we update debian-iptables and debian-hyperkube-base; there shouldn't be any issues, but hyperkube in particular has surprised me before.

/assign @ihmccreery @awly @tallclair

@awly

This comment has been minimized.

Contributor

awly commented Oct 18, 2018

/lgtm
Thanks for cleaning this up!

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 18, 2018

@ixdy

This comment has been minimized.

Member

ixdy commented Oct 19, 2018

/sig release

@k8s-ci-robot k8s-ci-robot added sig/release and removed needs-sig labels Oct 19, 2018

@ixdy

This comment has been minimized.

Member

ixdy commented Oct 19, 2018

/hold

I forgot to add the sig, but I've already promoted the debian-base image, so I'm going to bump the child images in this PR too.

VERSION=v8.8
KUBECTL_VERSION?=v1.10.7
VERSION=v8.9
KUBECTL_VERSION?=v1.10.9

This comment has been minimized.

@ixdy

ixdy Oct 19, 2018

Member

@MrHohn does this version of kubectl still make sense? or should we bump to 1.11.x?

This comment has been minimized.

@MrHohn

MrHohn Oct 19, 2018

Member

Thanks for adding me, bumping to 1.11.x sounds good to me.

This comment has been minimized.

@ixdy

ixdy Oct 19, 2018

Member

updated to kubectl v1.11.3.

@ixdy

This comment has been minimized.

Member

ixdy commented Oct 19, 2018

pushed a commit bumping the debian-base references, PTAL.

Update to debian-base 0.4.0
Additionally, update the addon-manager to use kubectl v1.11.3.
@@ -16,12 +16,12 @@
REGISTRY?="staging-k8s.gcr.io"
IMAGE=$(REGISTRY)/debian-iptables
TAG?=v10.2
TAG?=v11.0

This comment has been minimized.

@awly

awly Oct 19, 2018

Contributor

why not v10.3 ?

This comment has been minimized.

@ixdy

ixdy Oct 19, 2018

Member

I generally reserve the .N bumps for rebases of the existing image. We actually removed a package here.

@awly

This comment has been minimized.

Contributor

awly commented Oct 19, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 19, 2018

@ixdy

This comment has been minimized.

Member

ixdy commented Oct 19, 2018

/assign @zmerlynn

for cluster/ approval

@ixdy

This comment has been minimized.

Member

ixdy commented Oct 19, 2018

/retest

@zmerlynn

This comment has been minimized.

Member

zmerlynn commented Oct 19, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 19, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ixdy

This comment has been minimized.

Member

ixdy commented Oct 19, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 82cba09 into kubernetes:master Oct 19, 2018

18 checks passed

cla/linuxfoundation ixdy authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Job succeeded.
Details
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@ixdy ixdy referenced this pull request Oct 24, 2018

Merged

Update images after #69995 #70209

cdkbot pushed a commit to juju-solutions/kubernetes that referenced this pull request Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment