New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic audit plugins #70021

Merged
merged 2 commits into from Nov 10, 2018

Conversation

@pbarker
Copy link
Contributor

pbarker commented Oct 19, 2018

/kind feature

What this PR does / why we need it:
Adds apiserver plugins for dynamic audit configuration https://github.com/kubernetes/community/blob/master/keps/sig-auth/0014-dynamic-audit-configuration.md

Special notes for your reviewer:
This is a 2 part series with #67257 holding the handlers and completing the implementation

An umbrella issue containing items to be worked on before beta has been started #70816

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot requested review from CaoShuFeng and hzxuzhonghu Oct 19, 2018

@pbarker pbarker changed the title dynaimc audit plugins dynamic audit plugins Oct 19, 2018

@ncdc

This comment has been minimized.

Copy link
Member

ncdc commented Oct 19, 2018

/ok-to-test

@ncdc

This comment has been minimized.

Copy link
Member

ncdc commented Oct 19, 2018

/milestone 1.13

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 19, 2018

@ncdc: You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to set the milestone.

In response to this:

/milestone 1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timothysc timothysc added this to the v1.13 milestone Oct 19, 2018

@ncdc

This comment has been minimized.

Copy link
Member

ncdc commented Oct 19, 2018

@k8s-ci-robot k8s-ci-robot requested a review from tallclair Oct 19, 2018

@pbarker

This comment has been minimized.

Copy link
Contributor

pbarker commented Oct 19, 2018

/retest

@tallclair
Copy link
Member

tallclair left a comment

I think with a bit of refactoring you can shrink reduce this code quite a bit.

@pbarker pbarker force-pushed the pbarker:audit-plugins branch from 946fc2f to 59cf445 Oct 23, 2018

@pbarker pbarker force-pushed the pbarker:audit-plugins branch 4 times, most recently from 3dc2d1d to a9309cd Oct 23, 2018

@pbarker pbarker force-pushed the pbarker:audit-plugins branch from c5cc2e6 to c2dce6d Nov 8, 2018

@k8s-ci-robot k8s-ci-robot added sig/auth and removed lgtm labels Nov 8, 2018

@pbarker pbarker force-pushed the pbarker:audit-plugins branch 2 times, most recently from d90ee87 to 6db41bd Nov 8, 2018

@pbarker

This comment has been minimized.

Copy link
Contributor

pbarker commented Nov 8, 2018

/retest

@x13n

This comment has been minimized.

Copy link
Member

x13n commented Nov 9, 2018

/lgtm

pbarker added some commits Oct 19, 2018

@pbarker pbarker force-pushed the pbarker:audit-plugins branch from 6db41bd to 54fd930 Nov 9, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 9, 2018

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 9, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pbarker, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 9, 2018

/priority important-soon

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 9, 2018

/kind feature

@pbarker

This comment has been minimized.

Copy link
Contributor

pbarker commented Nov 10, 2018

/release-note-none

@pbarker

This comment has been minimized.

Copy link
Contributor

pbarker commented Nov 10, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 413ccb1 into kubernetes:master Nov 10, 2018

18 checks passed

cla/linuxfoundation pbarker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@pbarker pbarker deleted the pbarker:audit-plugins branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment