Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move internal apps API types out of extensions package #70028

Merged
merged 9 commits into from Oct 26, 2018

Conversation

@liggitt
Copy link
Member

commented Oct 19, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
related to #43214

Special notes for your reviewer:

  • removes unused CustomMetricTarget types
  • moves internal API types, fuzzing, validation, and conversion from extensions to apps
  • stops generating GetScale/UpdateScale for internal clients (since it doesn't work correctly)

The main commits that need review:

  • Change registration and custom conversion from extensions to apps
  • fixup extensions->apps references

The "move ..." commits are pure moves, no internal changes.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot requested review from caesarxuchao and dims Oct 19, 2018

@liggitt liggitt force-pushed the liggitt:move-extensions-types branch 2 times, most recently from b63cd06 to e84f7e8 Oct 19, 2018

@liggitt liggitt changed the title WIP - move extensions types out move internal API types out of extensions package Oct 19, 2018

@liggitt liggitt force-pushed the liggitt:move-extensions-types branch from e84f7e8 to 5b629bd Oct 19, 2018

@liggitt liggitt changed the title move internal API types out of extensions package move internal apps API types out of extensions package Oct 19, 2018

@soltysh soltysh referenced this pull request Oct 19, 2018

Open

stop serving extensions api group - umbrella issue #43214

25 of 36 tasks complete

@liggitt liggitt force-pushed the liggitt:move-extensions-types branch from 5b629bd to ea8dd57 Oct 19, 2018

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Oct 19, 2018

@jennybuckley

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2018

/assign @caesarxuchao

@caesarxuchao
Copy link
Member

left a comment

/lgtm

Fix the nits if you have to rebase anyway.

@@ -101,7 +101,7 @@ func TestSetControllerConversion(t *testing.T) {
},
}

t.Logf("rs._internal.extensions -> rs.v1beta1.extensions")
t.Logf("rs._internal.apps -> rs.v1beta1.apps")

This comment has been minimized.

Copy link
@caesarxuchao

caesarxuchao Oct 26, 2018

Member

nit: s/v1beta1.apps/v1.apps

@@ -116,7 +116,7 @@ func TestSetControllerConversion(t *testing.T) {
),
)

t.Logf("rs.v1beta1.extensions -> rc._internal")
t.Logf("rs.v1beta1.apps -> rc._internal")

This comment has been minimized.

Copy link
@caesarxuchao

@liggitt liggitt force-pushed the liggitt:move-extensions-types branch from 47ece9b to 572dfe6 Oct 26, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 26, 2018

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Oct 26, 2018

nits fixed, retagging

need /approve from @caesarxuchao for replication controller package and @timothysc for kubeadm package

@liggitt liggitt added the lgtm label Oct 26, 2018

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Oct 26, 2018

/assign @timothysc

transitive dependency changed from extensions to apps, updated cmd/kubeadm/.import-restrictions

@timothysc timothysc removed their assignment Oct 26, 2018

@timothysc

This comment has been minimized.

Copy link
Member

commented Oct 26, 2018

/approve

from the kubeadm side.

@caesarxuchao

This comment has been minimized.

Copy link
Member

commented Oct 26, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, liggitt, soltysh, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Oct 26, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 1df4f8e into kubernetes:master Oct 26, 2018

18 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:move-extensions-types branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.