New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch kubectl rollout to directly rolling back deployments #70039

Merged
merged 1 commit into from Oct 30, 2018

Conversation

@liggitt
Member

liggitt commented Oct 19, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Removes kubectl use of the extensions/v1beta1 rollback API, which is deprecated and removed in apps/v1. This is a prereq of switching to apps/v1 completely and stopping serving the extensions/v1beta1 API.

Also correctly returns error codes when trying to rollback a deployment to a non-existent revision

xref #43214

Does this PR introduce a user-facing change?:

`kubectl rollout undo` now returns errors when attempting to rollback a deployment to a non-existent revision
`kubectl rollout undo` no longer uses the deprecated extensions/v1beta1 rollback API, which means that Events are no longer emitted when rolling back a deployment
@liggitt

This comment has been minimized.

Member

liggitt commented Oct 19, 2018

@kow3ns

This comment has been minimized.

Member

kow3ns commented Oct 19, 2018

/assign @janetkuo

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added the kind/bug label Oct 20, 2018

@liggitt liggitt added this to the v1.13 milestone Oct 23, 2018

@janetkuo

This comment has been minimized.

Member

janetkuo commented Oct 24, 2018

Another user visible change is that rollback no longer emits events. Worth mentioning in the release note.

@liggitt

This comment has been minimized.

Member

liggitt commented Oct 25, 2018

comments addressed

@soltysh

lgtm, I'll let Janet have final saying

/cc @tnozicka

@k8s-ci-robot k8s-ci-robot requested a review from tnozicka Oct 25, 2018

Show resolved Hide resolved pkg/kubectl/rollback.go Outdated
Show resolved Hide resolved pkg/kubectl/rollback.go Outdated
Show resolved Hide resolved pkg/kubectl/rollback.go Outdated
Show resolved Hide resolved pkg/kubectl/rollback.go Outdated
Show resolved Hide resolved pkg/kubectl/util/deployment/deployment.go Outdated
Show resolved Hide resolved pkg/kubectl/rollback.go Outdated
@liggitt

This comment has been minimized.

Member

liggitt commented Oct 27, 2018

updated

@janetkuo

This comment has been minimized.

Member

janetkuo commented Oct 29, 2018

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 29, 2018

@k8s-ci-robot k8s-ci-robot merged commit 975e6c0 into kubernetes:master Oct 30, 2018

18 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:deployment-rollback branch Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment