New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SubPath printing #70127

Merged
merged 1 commit into from Nov 29, 2018

Conversation

@dtaniwaki
Copy link
Contributor

dtaniwaki commented Oct 23, 2018

What type of PR is this?

/kind bug

What this PR does / why we need it:

VolumeMounts section didn't print SubPath correctly because switch/case always take a flag of ReadOnly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

N/A

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?:

Fix `SubPath` printing of `VolumeMounts`.
@neolit123
Copy link
Member

neolit123 left a comment

LGTM

/ok-to-test
/kind bug
/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps and removed needs-sig labels Oct 23, 2018

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Oct 23, 2018

/ok-to-test

@dtaniwaki dtaniwaki force-pushed the dtaniwaki:print-sub-path branch from e26c458 to 016ecc2 Nov 16, 2018

@dtaniwaki

This comment has been minimized.

Copy link
Contributor Author

dtaniwaki commented Nov 16, 2018

@neolit123 I rebased the branch. Could you review it again?

@dtaniwaki dtaniwaki force-pushed the dtaniwaki:print-sub-path branch from 016ecc2 to 50f2014 Nov 16, 2018

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Nov 16, 2018

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 16, 2018

hi, it looks OK to me, but this is up to SIG-CLI for the final call if this is going to make 1.13.
code freeze is today. thanks.

@dtaniwaki dtaniwaki force-pushed the dtaniwaki:print-sub-path branch from 50f2014 to 6af299a Nov 16, 2018

@k8s-ci-robot k8s-ci-robot added size/S and removed size/M labels Nov 16, 2018

@dtaniwaki dtaniwaki force-pushed the dtaniwaki:print-sub-path branch from 6af299a to 49d762d Nov 16, 2018

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 16, 2018

/uncc

@dtaniwaki

This comment has been minimized.

Copy link
Contributor Author

dtaniwaki commented Nov 16, 2018

/retest

@dtaniwaki

This comment has been minimized.

Copy link
Contributor Author

dtaniwaki commented Nov 16, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

@dtaniwaki

This comment has been minimized.

Copy link
Contributor Author

dtaniwaki commented Nov 17, 2018

/retest

@dtaniwaki

This comment has been minimized.

Copy link
Contributor Author

dtaniwaki commented Nov 17, 2018

/assign @mengqiy

@soltysh
Copy link
Contributor

soltysh left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaniwaki, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mengqiy

This comment has been minimized.

Copy link
Contributor

mengqiy commented Nov 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit b385742 into kubernetes:master Nov 29, 2018

18 checks passed

cla/linuxfoundation dtaniwaki authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment