Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendor package github.com/coreos/... #70168

Merged
merged 1 commit into from Oct 31, 2018
Merged

Update vendor package github.com/coreos/... #70168

merged 1 commit into from Oct 31, 2018

Conversation

wgliang
Copy link
Contributor

@wgliang wgliang commented Oct 24, 2018 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:

Part of #69776 involves updating github.com/coreos/...

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 24, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2018
@wgliang
Copy link
Contributor Author

wgliang commented Oct 24, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 24, 2018
@wgliang wgliang changed the title Update vendor package github.com/coreos/etcd Update vendor package github.com/coreos Oct 24, 2018
@wgliang wgliang changed the title Update vendor package github.com/coreos Update vendor package github.com/coreos/... Oct 24, 2018
@wgliang wgliang force-pushed the update-vendor/coreos-etcd branch 2 times, most recently from 9745878 to 16a136d Compare October 24, 2018 06:36
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 24, 2018
@wgliang wgliang mentioned this pull request Oct 24, 2018
Closed
89 tasks
@jennybuckley
Copy link

cc @mbohlool

@wgliang
Copy link
Contributor Author

wgliang commented Oct 29, 2018

/ping @thockin @cblecker @sttts
PTAL

@dims
Copy link
Member

dims commented Oct 30, 2018

/assign @thockin
/assign @cblecker

@thockin
Copy link
Member

thockin commented Oct 31, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, wgliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9e31e65 into kubernetes:master Oct 31, 2018
@anton-johansson anton-johansson mentioned this pull request Feb 21, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbeda jbeda Awaiting requested review from jbeda

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@cblecker cblecker

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wgliang @jennybuckley @dims @thockin @k8s-ci-robot @cblecker