Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove golang fork for typecheck #70210

Merged
merged 4 commits into from Oct 25, 2018

Conversation

@cblecker
Copy link
Member

commented Oct 25, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Back in #59289, we added a new typecheck test, and it required modifications to go's types package (golang/go#23712). Those modifications aren't needed anymore, and as such, I'm updating this to remove the fork.

Does this PR introduce a user-facing change?:

NONE

cblecker added some commits Oct 25, 2018

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

Thanks for this, rmmh, has other things going on so I will take a look per discussion in #sig-testing :-)
/assign

@BenTheElder
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 25, 2018

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Oct 25, 2018

/assign @smarterclayton @lavalamp @thockin
Would one of you mind approving for the third_party/ removal? Thanks!

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Oct 25, 2018

/retest

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

@@ -43,7 +43,7 @@ var packageCases = []struct {
if err != unix.ENXIO {
panic("woops")
}
}`, map[string]string{"linux/amd64": "", "windows/amd64": "test.go:4:13: ENXIO not declared by package unix"}},
}`, map[string]string{"linux/amd64": "", "windows/amd64": "test.go:4:18: ENXIO not declared by package unix"}},

This comment has been minimized.

Copy link
@ixdy

ixdy Oct 25, 2018

Member

oh good, one of those tests. :)

@ixdy

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

why is test/typecheck/srcimporter/srcimporter.go not under third_party? that seems odd...

@lavalamp

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Oct 25, 2018

/hold
@ixdy actually, you're right. I think it's because we needed to modify it.

@cblecker cblecker force-pushed the cblecker:remove-golang-fork branch from 02b0c71 to 66fa276 Oct 25, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 25, 2018

@cblecker cblecker force-pushed the cblecker:remove-golang-fork branch from 66fa276 to 13f9121 Oct 25, 2018

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Oct 25, 2018

@ixdy okay, moved things over to third_party/. should be good for review

cblecker added some commits Oct 25, 2018

Update srcimporter.go to golang/go@5f0a9ba
Also move to third_party/ as it's copied code.
Fix typecheck test error message
extra characters due to whitespace differences

@cblecker cblecker force-pushed the cblecker:remove-golang-fork branch from 13f9121 to e415c1e Oct 25, 2018

@BenTheElder
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 25, 2018

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Oct 25, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 1975747 into kubernetes:master Oct 25, 2018

18 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:remove-golang-fork branch Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.