New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune all kubeapiserver internal informer/lister codes from k/k #70217

Merged
merged 3 commits into from Oct 29, 2018

Conversation

@yue9944882
Member

yue9944882 commented Oct 25, 2018

the hub/internal object types is only used thru the handler chain. now we remove internal informers/listers to restrict that usage.

@kubernetes/sig-api-machinery-misc

Does this PR introduce a user-facing change?:

NONE
@yue9944882

This comment has been minimized.

Member

yue9944882 commented Oct 25, 2018

/kind cleanup

@liggitt

This comment has been minimized.

Member

liggitt commented Oct 25, 2018

nice cleanup! I wonder if we can remove the internal clients as well.

@yue9944882

This comment has been minimized.

Member

yue9944882 commented Oct 25, 2018

@liggitt yuh huh. about to. i just tried that locally but it involves larger changes than i thought. will do it in another pull 😉

@jennybuckley

This comment has been minimized.

Contributor

jennybuckley commented Oct 25, 2018

cc @yliaog

@yue9944882 yue9944882 changed the title from Prune all internal informer/lister codes from k/k to Prune all kubeapiserver internal informer/lister codes from k/k Oct 26, 2018

@deads2k

This comment has been minimized.

Contributor

deads2k commented Oct 26, 2018

/lgtm

@deads2k

This comment has been minimized.

Contributor

deads2k commented Oct 26, 2018

/approve

Though it will need higher level approval.

@yliaog

This comment has been minimized.

Contributor

yliaog commented Oct 26, 2018

/lgtm

@yliaog

This comment has been minimized.

Contributor

yliaog commented Oct 26, 2018

/retest

@lavalamp

This comment has been minimized.

Member

lavalamp commented Oct 29, 2018

/approve

This is awesome!!!

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, lavalamp, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yliaog

This comment has been minimized.

Contributor

yliaog commented Oct 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 29, 2018

@k8s-ci-robot k8s-ci-robot merged commit c89d2cb into kubernetes:master Oct 29, 2018

18 checks passed

cla/linuxfoundation yue9944882 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment