Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor scheduler_test.go to use Clientset #70290
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Oct 26, 2018
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
This looks pretty good. I think overall, scheduler_test.go is already somewhat messy, but this PR is not about cleaning that up. Please look into the SelfLink thing, and then I'll approve.