New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate critical pod annotation #70298

Merged
merged 1 commit into from Oct 27, 2018

Conversation

@bsalamat
Contributor

bsalamat commented Oct 26, 2018

What type of PR is this?
/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Critical pod annotation is deprecated. Pod priority should be used instead to mark pods as critical.
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bsalamat bsalamat requested review from dims and ravisantoshgudimetla and removed request for thockin and brendandburns Oct 26, 2018

@k8s-ci-robot k8s-ci-robot removed the needs-sig label Oct 26, 2018

@ravisantoshgudimetla

This comment has been minimized.

Contributor

ravisantoshgudimetla commented Oct 26, 2018

/retest

@ravisantoshgudimetla

Thanks for the PR @bsalamat
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 26, 2018

@bsalamat

This comment has been minimized.

Contributor

bsalamat commented Oct 26, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit a3eebe9 into kubernetes:master Oct 27, 2018

18 checks passed

cla/linuxfoundation bsalamat authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment