Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Use SSL health checks for ELBs when backend protocol is SSL/HTTPS #70309
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
referenced this pull request
Oct 26, 2018
Not sure where you heard I'm no longer reviewing PRs, though I'm certainly not able to keep up in a timely manner...
The test failures are due to an issue with the payments on the AWS account used for testing and are being worked on.
Code looks good and because it's an beta annotation I think we're OK to fix it as a straight bug.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
3 similar comments
8 similar comments
@2rs2ts: The following test failed, say