New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aws provider to handle only EBS volumes #70432

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@mvladev
Copy link
Contributor

mvladev commented Oct 30, 2018

What type of PR is this?
/kind bug

What this PR does / why we need it:
When the cloud-controller-manager is running with PV label initializing controller and NFS volume is created, it causes nil pointer dereference error.

Which issue(s) this PR fixes:
Fixes #68996

Special notes for your reviewer:
I'll fix OpenStack and GCE in subsequent PR.

Does this PR introduce a user-facing change?:

Fix cloud-controller-manager crash when using AWS provider and PersistentVolume initializing controller 

/sig cloud-provider
/sig aws

@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Oct 30, 2018

/ok-to-test

Looks right - thanks @mvladev

/lgtm

fix aws provider to handle only EBS volumes
When the cloud-controller-manager is running with PV label initializing controller
and NFS volume is created, it causes nill reference error.

fixes #68996

@mvladev mvladev force-pushed the mvladev:fix-cloud-provider-aws branch from 7f33f25 to fa80dd5 Oct 30, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 30, 2018

@mvladev

This comment has been minimized.

Copy link
Contributor Author

mvladev commented Oct 30, 2018

@justinsb updated bazel BUILD files.

@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Oct 30, 2018

That'll teach you to try to add tests @mvladev ;-)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 30, 2018

@mvladev

This comment has been minimized.

Copy link
Contributor Author

mvladev commented Oct 30, 2018

/retest

@mvladev

This comment has been minimized.

Copy link
Contributor Author

mvladev commented Nov 5, 2018

/poke @justinsb

Also there is a PR which you might want to have a look into #70533

@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Nov 28, 2018

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mvladev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Nov 28, 2018

Probably we shouldn't merge before #70533 though!

@k8s-ci-robot k8s-ci-robot merged commit d2ca519 into kubernetes:master Nov 29, 2018

18 checks passed

cla/linuxfoundation mvladev authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment