New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retainKeys patchStrategy in apps/deployments #70436

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
4 participants
@liggitt
Member

liggitt commented Oct 30, 2018

What type of PR is this?
/kind bug

What this PR does / why we need it:
The tests to ensure a deployment strategy can be switched from rollback to recreate by kubectl apply without explicitly clearing the rollback-related fields depends on the retainKeys merge strategy.

As part of switching to apps/v1, the tests that ensure that capability failed, and it was discovered the patch strategy was not set on apps deployments as expected.

Special notes for your reviewer:
Extracted from #70370 for easier review

xref #50296

`kubectl apply` can now change a deployment strategy from rollout to recreate without explicitly clearing the rollout-related fields

/assign @kow3ns

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 30, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Member

liggitt commented Oct 30, 2018

/assign @mengqiy

@mengqiy

This comment has been minimized.

Contributor

mengqiy commented Oct 31, 2018

/lgtm
Closes #60340

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 31, 2018

@k8s-ci-robot k8s-ci-robot merged commit 797f5af into kubernetes:master Oct 31, 2018

18 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:retain-keys branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment