New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license header to non-generated proto files #70440

Merged
merged 1 commit into from Nov 29, 2018

Conversation

@nikhita
Copy link
Member

nikhita commented Oct 30, 2018

As a part of kubernetes/sig-release#223.
/sig release
/kind cleanup

Does this PR introduce a user-facing change?:

NONE
@@ -1,3 +1,19 @@
/*
Copyright 2018 The Kubernetes Authors.

This comment has been minimized.

@nikhita

nikhita Oct 30, 2018

Author Member

This file was added in 2018: #58973.

@@ -1,3 +1,19 @@
/*
Copyright 2018 The Kubernetes Authors.

This comment has been minimized.

@nikhita

nikhita Oct 30, 2018

Author Member

This file was added in 2018: #63328.

@@ -1,3 +1,19 @@
/*
Copyright 2018 The Kubernetes Authors.

This comment has been minimized.

@nikhita

nikhita Oct 30, 2018

Author Member

This file was added in 2018: #63328.

@@ -1,3 +1,19 @@
/*
Copyright 2018 The Kubernetes Authors.

This comment has been minimized.

@nikhita

nikhita Oct 30, 2018

Author Member

This file was added in 2018: #55684.

@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Oct 30, 2018

/lgtm

Looks good - are you also fixing up the header validation checks so this doesn't happen again @nikhita ? I'm happy to (try) if you're not working on it...

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented Oct 30, 2018

Looks good - are you also fixing up the header validation checks so this doesn't happen again @nikhita ? I'm happy to (try) if you're not working on it...

There is a hack/verify-boilerplate.sh script present, but I think it somehow missed these because these are .proto files but are not generated. I'll look into fixing the script. 👍

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented Oct 30, 2018

@k8s-ci-robot k8s-ci-robot requested a review from justaugustus Oct 30, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 30, 2018

@nikhita: GitHub didn't allow me to request PR reviews from the following users: swinslow.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @justaugustus @dims @swinslow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from dims Oct 30, 2018

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented Oct 30, 2018

@justinsb btw, thanks for the quick lgtm! :)

@swinslow

This comment has been minimized.

Copy link

swinslow commented Oct 30, 2018

lgtm

thanks nikhita!

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Oct 30, 2018

/lgtm
/approve

@mbohlool

This comment has been minimized.

Copy link
Member

mbohlool commented Nov 1, 2018

/assign

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Nov 9, 2018

This looks like it's ready for approval.
/assign @tallclair @timothysc

@timothysc
Copy link
Member

timothysc left a comment

/lgtm
/approve

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Nov 14, 2018

/milestone v1.13

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 19, 2018

@nikhita @timothysc @tallclair how critical is this for 1.13? we are in code freeze and if possible, I would like to defer this until 1.14. let me know otherwise

/remove-priority critical-urgent

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 19, 2018

/remove-priority critical-urgent

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 19, 2018

@AishSundar: Those labels are not set on the issue: priority/critical-urgent

In response to this:

/remove-priority critical-urgent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Nov 19, 2018

Sounds good, @AishSundar

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 19, 2018

/milestone v1.14

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.13, v1.14 Nov 19, 2018

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented Nov 19, 2018

Yeah, this can wait. I'll look into fixing the script till then.

@tallclair

This comment has been minimized.

Copy link
Member

tallclair commented Nov 28, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, nikhita, tallclair, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d0ac922 into kubernetes:master Nov 29, 2018

18 checks passed

cla/linuxfoundation nikhita authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment