New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent sorting of PATH dirs for kubectl plugins #70443

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
3 participants
@juanvallejo
Member

juanvallejo commented Oct 30, 2018

This patch allows the kubectl plugin list command to display discovered
plugin paths in the same order as they appear in a user's PATH.
Prior to this patch, discovered plugin paths were sorted before being
displayed.

Additionally, any errors encountered while reading from any directory in a
user's PATH will now be printed to stderr at the end of the command's
output.

/kind bug

Does this PR introduce a user-facing change?:

The `kubectl plugin list` command will now display discovered plugin paths in the same order as they are found in a user's PATH variable.

/sig cli

cc @soltysh @seans3

@k8s-ci-robot k8s-ci-robot requested review from rootfs and soltysh Oct 30, 2018

@juanvallejo juanvallejo changed the title from prevent sorting of PATH dirs to prevent sorting of PATH dirs for kubectl plugins Oct 30, 2018

prevent sorting of PATH dirs
This patch allows the `kubectl plugin list` command to display discovered
plugin paths in the same order as they appear in a user's PATH.
Prior to this patch, discovered plugin paths were sorted before being
displayed.

Additionally, any errors encountered while reading from any directory in a
user's PATH will now be printed to stderr at the end of the command's
output.
@seans3

This comment has been minimized.

Collaborator

seans3 commented Oct 30, 2018

/lgtm

@seans3

This comment has been minimized.

Collaborator

seans3 commented Oct 30, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 30, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 59625d8 into kubernetes:master Oct 30, 2018

18 checks passed

cla/linuxfoundation juanvallejo authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@juanvallejo juanvallejo deleted the juanvallejo:jvallejo/plugin-list-improvements branch Oct 31, 2018

jpetazzo added a commit to jpetazzo/container.training that referenced this pull request Nov 2, 2018

Work around bug in kubectl logs
kubectl logs -l ... --tail ... is buggy.
(It always returns 10 lines of output instead
of the requested number.)

This works around the problem, by adding extra
explanations of the issue and providing a shell
function as a workaround.

See kubernetes/kubernetes#70443 for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment