New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rules_go 0.16.2 and gazelle 0.15.0 #70456

Merged
merged 2 commits into from Nov 6, 2018

Conversation

@ixdy
Copy link
Member

ixdy commented Oct 30, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it: updating brings some minor new features and bugfixes, but the most notable thing is not breaking in bazel 0.20+ when the CC API changes.

Updating gazelle also brings in autogazelle, which is not yet being used, but is worth experimentation.

Note that these changes require bazel 0.17.2+. This version of bazel has been out for over a month.

Does this PR introduce a user-facing change?:

NONE

/assign @BenTheElder @thockin
/sig release testing

@BenTheElder
Copy link
Member

BenTheElder left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 31, 2018

@ixdy ixdy force-pushed the ixdy:update-rules_go-0.17.2 branch from 91ecf38 to 13618c3 Nov 2, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 2, 2018

@ixdy ixdy changed the title Update to rules_go 0.17.2 and gazelle 0.15.0 Update to rules_go 0.16.1 and gazelle 0.15.0 Nov 2, 2018

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Nov 2, 2018

fixed the commit messages, since I mixed up the bazel version and rules_go version.

@thockin can I get approval please?

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 2, 2018

@BenTheElder
Copy link
Member

BenTheElder left a comment

/lgtm

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Nov 5, 2018

/hold

There's going to be another rules_go release this week with support for go1.11.2.

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Nov 5, 2018

/approve
for the deps bump

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ixdy added some commits Oct 30, 2018

@ixdy ixdy force-pushed the ixdy:update-rules_go-0.17.2 branch from 13618c3 to 52a08dd Nov 5, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 5, 2018

@ixdy ixdy changed the title Update to rules_go 0.16.1 and gazelle 0.15.0 Update to rules_go 0.16.2 and gazelle 0.15.0 Nov 5, 2018

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Nov 5, 2018

/hold cancel

This now updates to rules_go 0.16.2, which includes support for go1.11.2.

PTAL?

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Nov 5, 2018

note that I have not bumped the go version in this PR.

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 5, 2018

@BenTheElder
Copy link
Member

BenTheElder left a comment

/lgtm

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Nov 5, 2018

LGTM

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Nov 6, 2018

/retest

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Nov 6, 2018

/joke

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 6, 2018

@ixdy: Did you know that protons have mass? I didn't even know they were catholic.

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 5960971 into kubernetes:master Nov 6, 2018

18 checks passed

cla/linuxfoundation ixdy authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment