New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: Writable to ReadOnly in HostPathMount #70495

Merged
merged 1 commit into from Nov 3, 2018

Conversation

@rosti
Contributor

rosti commented Oct 31, 2018

What type of PR is this?
/kind api-change

What this PR does / why we need it:

Writable was added to HostPathMount in v1alpha1 in order to control if an extra volume is mounted in read only or writable mode.
Usually, in Kubernetes, this option is referred to as ReadOnly, instead of Writable and is defaulted to false. However, at the time, all extra volumes to pods were defaulted to read-only. Therefore, to avoid changes to existing v1alpha1 configs, this option had to be added with reversed meaning.

Hence, it's called writable.

Now, with the migration towards v1beta1, we can safely change this to ReadOnly and get it in sync with the reset of Kubernetes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Refs kubernetes/kubeadm#911

Special notes for your reviewer:

This PR depends on:

Please, review only the last commit here.

/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/area kubeadm
/assign @fabriziopandini
/assign @timothysc

Does this PR introduce a user-facing change?:

kubeadm: The writable config file option for extra volumes is renamed to readOnly with a reversed meaning. With readOnly defaulted to false (as in pod specs).

@rosti rosti changed the title from kubeadm: Writable to ReadOnly in HostPathMount to [WIP] kubeadm: Writable to ReadOnly in HostPathMount Oct 31, 2018

@rosti

This comment has been minimized.

Contributor

rosti commented Oct 31, 2018

Needs a test case or two, so I'll mark it as WIP for now.

@rosti rosti changed the title from [WIP] kubeadm: Writable to ReadOnly in HostPathMount to kubeadm: Writable to ReadOnly in HostPathMount Nov 1, 2018

@rosti

This comment has been minimized.

Contributor

rosti commented Nov 1, 2018

This one is ready for review now.

@timothysc

/approve

I don't see an issue with the change, but rebase required.

@fabriziopandini

Thanks @rosti!
/approve
Waiting for dependency to merge before final lgtm

kubeadm: Writable to ReadOnly in HostPathMount
Writable was added to HostPathMount in v1alpha1 in order to control if an extra
volume is mounted in read only or writable mode.
Usually, in Kubernetes, this option is referred to as ReadOnly, instead of
Writable and is defaulted to `false`. However, at the time, all extra volumes
to pods were defaulted to read-only. Therefore, to avoid changes to existing
v1alpha1 configs, this option had to be added with reversed meaning.

Hence, it's called `writable`.

Now, with the migration towards v1beta1, we can safely change this to ReadOnly
and get it in sync with the reset of Kubernetes.

Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
@neolit123

This comment has been minimized.

Member

neolit123 commented Nov 2, 2018

/retest

@fabriziopandini

This comment has been minimized.

Contributor

fabriziopandini commented Nov 3, 2018

@rosti great work!
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 3, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, rosti, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 474e27f into kubernetes:master Nov 3, 2018

18 checks passed

cla/linuxfoundation rosti authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment