kubeadm: Writable to ReadOnly in HostPathMount #70495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
kind/api-change
rosti
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Needs a test case or two, so I'll mark it as WIP for now. |
rosti
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
rosti
force-pushed
the
writable-to-readonly-volumes
branch
from
6acc816
to
1b7cc82
Compare
k8s-ci-robot
added
size/XL
|
This one is ready for review now. |
3 tasks
timothysc
added
the
do-not-merge/blocked-paths
timothysc
reviewed
Nov 1, 2018
k8s-ci-robot
added
the
approved
fabriziopandini
approved these changes
Nov 2, 2018
There was a problem hiding this comment.
Thanks @rosti!
/approve
Waiting for dependency to merge before final lgtm
Writable was added to HostPathMount in v1alpha1 in order to control if an extra volume is mounted in read only or writable mode. Usually, in Kubernetes, this option is referred to as ReadOnly, instead of Writable and is defaulted to `false`. However, at the time, all extra volumes to pods were defaulted to read-only. Therefore, to avoid changes to existing v1alpha1 configs, this option had to be added with reversed meaning. Hence, it's called `writable`. Now, with the migration towards v1beta1, we can safely change this to ReadOnly and get it in sync with the reset of Kubernetes. Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
rosti
force-pushed
the
writable-to-readonly-volumes
branch
from
1b7cc82
to
6c9e347
Compare
k8s-ci-robot
added
size/L
|
/retest |
|
@rosti great work! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, rosti, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Writable was added to HostPathMount in v1alpha1 in order to control if an extra volume is mounted in read only or writable mode.
Usually, in Kubernetes, this option is referred to as ReadOnly, instead of Writable and is defaulted to
false. However, at the time, all extra volumes to pods were defaulted to read-only. Therefore, to avoid changes to existing v1alpha1 configs, this option had to be added with reversed meaning.Hence, it's called
writable.Now, with the migration towards v1beta1, we can safely change this to ReadOnly and get it in sync with the reset of Kubernetes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Refs kubernetes/kubeadm#911
Special notes for your reviewer:
This PR depends on:
Please, review only the last commit here.
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/area kubeadm
/assign @fabriziopandini
/assign @timothysc
Does this PR introduce a user-facing change?: