New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error log for 'no rollbacker has been implemented for ReplicationController' #70619

Merged
merged 1 commit into from Jan 12, 2019

Conversation

@taragu
Copy link
Contributor

taragu commented Nov 3, 2018

Fixing issue #69106

/sig testing
/area test
/kind cleanup
/assign @BenTheElder

Does this PR introduce a user-facing change?: No

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 3, 2018

Hi @taragu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from adohe and derekwaynecarr Nov 3, 2018

@taragu

This comment has been minimized.

Copy link
Contributor

taragu commented Nov 7, 2018

@adohe @derekwaynecarr have you guys looked at this PR yet? any suggestion will be greatly appreciated. thank you in advance! 🙂

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Nov 9, 2018

/ok-to-test
You should add this to the end of the PR opening comment:

```release-note
NONE
```

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Nov 9, 2018

/priority important-longterm

@taragu

This comment has been minimized.

Copy link
Contributor

taragu commented Nov 13, 2018

@BenTheElder @adohe @derekwaynecarr do you guys have any additional feedback for this feedback? thanks!

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Dec 19, 2018

I don't know enough about these scripts, we should get @kubernetes/sig-cli-maintainers to review

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 19, 2018

/cc @enj

@k8s-ci-robot k8s-ci-robot requested a review from enj Dec 19, 2018

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 20, 2018

I think what #69106 was asking for was a backtrace printed in test failures that showed what line the test failed on, not a hard coded error message comparison for this one spot

@enj

This comment has been minimized.

Copy link
Member

enj commented Dec 20, 2018

I think what #69106 was asking for was a backtrace printed in test failures that showed what line the test failed on, not a hard coded error message comparison for this one spot

Yeah, that was my intent.

@taragu

This comment has been minimized.

Copy link
Contributor

taragu commented Dec 21, 2018

@enj ah I see. So would you like to add information like

I0926 01:04:33.532] has not:no rollbacker has been implemented for {"" "ReplicationController"}
I0926 01:04:33.533] 433 /go/src/k8s.io/kubernetes/test/cmd/../../test/cmd/generic-resources.sh

to the call tree?

@taragu taragu force-pushed the taragu:surface-error-replication-controller branch from 9cc6e4b to 492c042 Jan 10, 2019

@taragu

This comment has been minimized.

Copy link
Contributor

taragu commented Jan 10, 2019

So I tried reproducing original issue #69106 by forcing the output_message to not contain no rollbacker has been implemented for "ReplicationController" and here are the error logs:

generic-resources.sh:428: Successful get rc {{range.items}}{{.metadata.name}}:{{end}}: busybox0:busybox1:
has not:no rollbacker has been implemented for "ReplicationController"
435 /Users/guw@ibm.com/go/src/k8s.io/kubernetes/test/cmd/../../test/cmd/generic-resources.sh
!!! [0105 16:08:50] Call tree:
!!! [0105 16:08:50]  1: /Users/guw@ibm.com/go/src/k8s.io/kubernetes/test/cmd/../../third_party/forked/shell2junit/sh2ju.sh:47 run_recursive_resources_tests(...)
!!! [0105 16:08:50]  2: /Users/guw@ibm.com/go/src/k8s.io/kubernetes/test/cmd/../../third_party/forked/shell2junit/sh2ju.sh:112 eVal(...)
!!! [0105 16:08:50]  3: /Users/guw@ibm.com/go/src/k8s.io/kubernetes/test/cmd/legacy-script.sh:133 juLog(...)
!!! [0105 16:08:50]  4: /Users/guw@ibm.com/go/src/k8s.io/kubernetes/test/cmd/legacy-script.sh:525 record_command(...)
!!! [0105 16:08:50]  5: hack/make-rules/test-cmd.sh:109 runTests(...)
+++ exit code: 1
+++ error: 1

This output is different than the one shown in the original issue probably because the original issue had other errors as well. We can still see the error as the line right before the call tree in the logs I have above, even though the call tree can be confusing because it doesn't go down to the level of generic-resource.sh which is where the error comes from. The call tree shows sh2ju.sh instead because all test runs are wrapped by function run_command which stores the test logs in an xml file and sh2ju.sh is the utility being used.

So to make it less confusing, I've removed the call to run_command so it doesn't show the irrelevant calls in the call tree. However, all other tests in legacy-script.sh use run_command. I think we probably run into the same problem for those other tests as well. Here's what the output looks like after removing run_command:

generic-resources.sh:428: Successful get rc {{range.items}}{{.metadata.name}}:{{end}}: busybox0:busybox1:
has not:no rollbacker has been implemented for "ReplicationController"
437 /Users/guw@ibm.com/go/src/k8s.io/kubernetes/test/cmd/../../test/cmd/generic-resources.sh
!!! [0110 16:39:25] Call tree:
!!! [0110 16:39:25]  1: /Users/guw@ibm.com/go/src/k8s.io/kubernetes/test/cmd/legacy-script.sh:526 run_recursive_resources_tests(...)
!!! [0110 16:39:25]  2: hack/make-rules/test-cmd.sh:125 runTests(...)

@enj @liggitt please let me know what you think of not using run_command here to call the test.

Also thank you @stevekuznetsov for helping me with this issue!! 😄

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor

stevekuznetsov commented Jan 11, 2019

@BenTheElder @ixdy might have reviews on the bash as well :)

@BenTheElder
Copy link
Member

BenTheElder left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 11, 2019

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Jan 11, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, taragu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Jan 11, 2019

Thanks for tackling this :-)

@taragu

This comment has been minimized.

Copy link
Contributor

taragu commented Jan 11, 2019

/test pull-kubernetes-integration

1 similar comment
@taragu

This comment has been minimized.

Copy link
Contributor

taragu commented Jan 11, 2019

/test pull-kubernetes-integration

@taragu

This comment has been minimized.

Copy link
Contributor

taragu commented Jan 11, 2019

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-gce-100-performance

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 12, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@taragu

This comment has been minimized.

Copy link
Contributor

taragu commented Jan 12, 2019

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot k8s-ci-robot merged commit 5fa52d6 into kubernetes:master Jan 12, 2019

18 checks passed

cla/linuxfoundation taragu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment