Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use go1.11.2 #70665

Merged
merged 1 commit into from Nov 6, 2018

Conversation

@cblecker
Copy link
Member

cblecker commented Nov 5, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Update to use go1.11.2

Which issue(s) this PR fixes:
Fixes #70631
Depends on #70456

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to use go1.11.2
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker cblecker changed the title Update to use go1.11.2 [WIP] Update to use go1.11.2 Nov 5, 2018

@k8s-ci-robot k8s-ci-robot requested review from mkumatag and zmerlynn Nov 5, 2018

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Nov 5, 2018

/assign @ixdy
/cc @AishSundar
/priority important-soon

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Nov 5, 2018

/sig release

urls = mirror("https://github.com/bazelbuild/rules_go/releases/download/0.15.4/rules_go-0.15.4.tar.gz"),
sha256 = "548f2ca9318c6a4393cdb4d80be09c0c85da0ed90eaf72820ac03786b09f7e9b",
strip_prefix = "rules_go-36605c479ee09646734278c24c6b4abea5aef9c9",
urls = mirror("https://github.com/bazelbuild/rules_go/archive/36605c479ee09646734278c24c6b4abea5aef9c9.tar.gz"),

This comment has been minimized.

Copy link
@ixdy

ixdy Nov 5, 2018

Member

I'd prefer to wait for a release (I imagine there will be one in the next day or two)

This comment has been minimized.

Copy link
@cblecker

cblecker Nov 5, 2018

Author Member

@ixdy Yeah, I agree. If you look at the commits, I've got a placeholder commit for the next version bump, and then a WIP commit to use this HEAD so that we can verify that bazel-test and bazel-build pass.

This comment has been minimized.

Copy link
@ixdy

ixdy Nov 5, 2018

Member

I'll include the new rules_go bump in #70456, but I'll reserve the go version bump for this PR.

This comment has been minimized.

Copy link
@cblecker

cblecker Nov 5, 2018

Author Member

Oh! Okay. Well then I'll wait for bazel-test to pass, then I'll drop those commits from this PR completely.

This comment has been minimized.

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Nov 5, 2018

other than that, this LGTM.

I'll work on building the new crossbuild image.

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 5, 2018

/hold
/lgtm

I prefer to hold for the actual release and the images as well. Thanks @cblecker !

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 5, 2018

/cc @jberkus

@k8s-ci-robot k8s-ci-robot requested a review from jberkus Nov 5, 2018

@cblecker cblecker force-pushed the cblecker:go-1.11.2 branch from df0b401 to b71e746 Nov 5, 2018

@k8s-ci-robot k8s-ci-robot added size/XS and removed lgtm size/S labels Nov 5, 2018

@cblecker cblecker changed the title [WIP] Update to use go1.11.2 Update to use go1.11.2 Nov 5, 2018

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Nov 5, 2018

/test pull-kubernetes-cross

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Nov 6, 2018

/retest

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Nov 6, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 6, 2018

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Nov 6, 2018

/test pull-kubernetes-e2e-kops-aws

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Nov 6, 2018

Cancelling the hold as the bazel bump was handled in #70456 (with the actual released tag) so #70665 (comment) doesn't apply anymore.
/hold cancel

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Nov 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit c2aa358 into kubernetes:master Nov 6, 2018

18 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

randomvariable added a commit to randomvariable/cluster-api-provider-aws that referenced this pull request Nov 6, 2018

Bump Go version to 1.12 to match
kubernetes/kubernetes/pull/70665

Signed-off-by: Naadir Jeewa <naadir@randomvariable.co.uk>

@randomvariable randomvariable referenced this pull request Nov 6, 2018

Merged

Bump Go to 1.11.2 #363

randomvariable added a commit to randomvariable/cluster-api-provider-aws that referenced this pull request Nov 6, 2018

Bump Go version to 1.12 to match
kubernetes/kubernetes/pull/70665

Signed-off-by: Naadir Jeewa <naadir@randomvariable.co.uk>

@cblecker cblecker deleted the cblecker:go-1.11.2 branch Nov 6, 2018

k8s-ci-robot added a commit to kubernetes-sigs/cluster-api-provider-aws that referenced this pull request Nov 6, 2018

Bump Go to 1.11.2 (#363)
* Bump Go version to 1.12 to match
kubernetes/kubernetes/pull/70665

Signed-off-by: Naadir Jeewa <naadir@randomvariable.co.uk>

* Lint WORKSPACE

Signed-off-by: Naadir Jeewa <naadir@randomvariable.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.