Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added field selector for listing pods #7067

Merged
merged 1 commit into from Apr 22, 2015

Conversation

@ravigadde
Copy link
Contributor

commented Apr 20, 2015

Added a field selector for listing pods

@googlebot

This comment has been minimized.

Copy link

commented Apr 20, 2015

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added the cla: no label Apr 20, 2015

@ravigadde

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2015

I authored the commits.

On Mon, Apr 20, 2015 at 1:33 PM, googlebot notifications@github.com wrote:

We found a Contributor License Agreement for you (the sender of this pull
request) and all commit authors, but as best as we can tell these commits
were authored by someone else. If that's the case, please add them to this
pull request and have them confirm that they're okay with these commits
being contributed to Google. If we're mistaken and you did author these
commits, just reply here to confirm.


Reply to this email directly or view it on GitHub
#7067 (comment)
.

@brendandburns

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2015

You need to sign the CLA, details in CONTRIBUTING.md

@brendandburns

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2015

This LGTM, modulo getting the CLA signed.

@ravigadde

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2015

@brendanburns I think there is some confusion between individual and corporate CLAs. I had originally signed an individual CLA. After signing the corporate CLA, I started seeing this error. I have now added my corporate email to my github account. Hope that helps.

@ravigadde ravigadde force-pushed the ravigadde:master branch from 8fc4902 to c0182c6 Apr 21, 2015

@googlebot

This comment has been minimized.

Copy link

commented Apr 21, 2015

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 21, 2015

@ravigadde ravigadde force-pushed the ravigadde:master branch from c0182c6 to 24f2f88 Apr 21, 2015

@fgrzadkowski

This comment has been minimized.

Copy link
Member

commented Apr 21, 2015

LGTM.

Can you please look into travis/shippable failures?

@ravigadde ravigadde force-pushed the ravigadde:master branch from 8aaba33 to bf8f258 Apr 21, 2015

@ravigadde

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2015

Fixed the travis issue. Can anyone tell me what the shippable failure is? I cant see it.

@fgrzadkowski

This comment has been minimized.

Copy link
Member

commented Apr 22, 2015

F0421 13:48:12.847654 3342 integration.go:393] static-pod-from-manifest FAILED: mirror pod has not been created or is not running: timed out waiting for the condition
!!! Error in ./hack/test-integration.sh:47
'"${KUBE_OUTPUT_HOSTBIN}/integration" --v=2 --apiVersion="$1" --maxConcurrency="${KUBE_INTEGRATION_TEST_MAX_CONCURRENCY}"' exited with status 255
Call stack:
1: ./hack/test-integration.sh:47 runTests(...)
2: ./hack/test-integration.sh:61 main(...)
Exiting with status 1

bgrant0607 added a commit that referenced this pull request Apr 22, 2015
Merge pull request #7067 from ravigadde/master
Added field selector for listing pods

@bgrant0607 bgrant0607 merged commit 15c2986 into kubernetes:master Apr 22, 2015

3 of 4 checks passed

Shippable Builds failed on Shippable
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0%) to 53.39%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.