Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16] Stop serving deprecated beta workload APIs #70672

Merged
merged 2 commits into from Jun 22, 2019

Conversation

@liggitt
Copy link
Member

commented Nov 5, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • Disables default serving of apps/v1beta1, apps/v1beta2, and deprecated extensions/v1beta1 APIs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

xref #43214

Does this PR introduce a user-facing change?:

The following APIs are no longer served by default:
* All resources under `apps/v1beta1` and `apps/v1beta2` - use `apps/v1` instead
* `daemonsets`, `deployments`, `replicasets` resources under `extensions/v1beta1` - use `apps/v1` instead
* `networkpolicies` resources under `extensions/v1beta1` - use `networking.k8s.io/v1` instead
* `podsecuritypolicies` resources under `extensions/v1beta1` - use `policy/v1beta1` instead

Serving these resources can be temporarily re-enabled using the `--runtime-config` apiserver flag. 
* `apps/v1beta1=true`
* `apps/v1beta2=true`
* `extensions/v1beta1/daemonsets=true,extensions/v1beta1/deployments=true,extensions/v1beta1/replicasets=true,extensions/v1beta1/networkpolicies=true,extensions/v1beta1/podsecuritypolicies=true`

The ability to serve these resources will be completely removed in v1.18.
@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2019

@liggitt liggitt added the lgtm label Jun 22, 2019

@k8s-ci-robot k8s-ci-robot merged commit 86e5099 into kubernetes:master Jun 22, 2019

23 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:stop-serving-beta-apps branch Jun 22, 2019

@neolit123

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

would it make sense to have this as an item under "action required"?

existing manifests (e.g. CNI deployments) trying to be applied against latest k/k master will fail if they are using: extensions/v1beta1. this hints that CNI providers may have to adapt.

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2019

Definitely, tagged

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

"CNI providers may..." = We goofed that in kind. Whoops 🙃 .. fixed now. Hopefully everyone else long since migrated when the APIs went stable 😉

adelina-t added a commit to e2e-win/flannel-kubernetes that referenced this pull request Jun 24, 2019

Update kube-flannel-l2bridge.yml
Update flannel manifest endpoints for DaemonSet & PodSecurityPolicy.

kubernetes/kubernetes#70672

adelina-t added a commit to e2e-win/flannel-kubernetes that referenced this pull request Jun 24, 2019

Update kube-flannel-vxlan.yml
Update flannel manifest API endpoints for PodSecurityPolicy and DaemonSet.

Note: kubernetes/kubernetes#70672

benmoss added a commit to pivotal-k8s/kubo-release that referenced this pull request Jun 24, 2019

Update deployment api versions
extensions/v1beta1 has been removed in kubernetes/kubernetes#70672

@mboersma mboersma referenced this pull request Jun 25, 2019

Merged

chore: replace deprecated extensions/v1beta APIs for 1.16 #1527

1 of 4 tasks complete

@cofyc cofyc referenced this pull request Jun 26, 2019

Merged

Fix GCE-latest testing #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.