/kubernetes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for file exec #70756

Merged
merged 2 commits into from Nov 30, 2018

Conversation

Reviewers

@davidz627 davidz627

@jsafrane jsafrane

Assignees

@jsafrane jsafrane

@davidz627 davidz627

Labels
approved cncf-cla: yes kind/bug lgtm priority/important-soon release-note-none sig/storage sig/testing size/L
Projects
None yet
Milestone
No milestone
5 participants
@msau42 @k8s-ci-robot @jsafrane @davidz627 @fejta-bot
@msau42
Copy link
Member

msau42 commented Nov 7, 2018 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
Adds test case for file exec from a volume.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none kind/bug size/M cncf-cla: yes needs-sig needs-priority labels Nov 7, 2018

@k8s-ci-robot

This comment has been minimized.

Sign in to view
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved sig/testing labels Nov 7, 2018

@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 7, 2018

@kubernetes/sig-storage-pr-reviews

@k8s-ci-robot k8s-ci-robot added sig/storage and removed needs-sig labels Nov 7, 2018

@k8s-ci-robot k8s-ci-robot requested review from davidz627 and jsafrane Nov 7, 2018

@msau42 msau42 force-pushed the msau42:add-io-exec-test branch from 6097902 to 615c91d Nov 8, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Nov 8, 2018

@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 8, 2018

cc @mkimuram I refactored the DriverInfo to add a capabilities map

@msau42 msau42 force-pushed the msau42:add-io-exec-test branch from 615c91d to c3baa95 Nov 8, 2018

@msau42 msau42 referenced this pull request Nov 8, 2018

Merged

Make csi drivers and in-tree drivers share e2e tests #68025

@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 8, 2018

cc @verult for plugin capabilities
@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 8, 2018

/hold
This is failing on pd csi driver

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold label Nov 8, 2018

@davidz627

davidz627 reviewed Nov 8, 2018
View changes

Show resolved Hide resolved test/e2e/storage/testsuites/volumes.go
Show resolved Hide resolved test/e2e/storage/testsuites/volumes.go
Show resolved Hide resolved test/e2e/storage/testsuites/volumes.go Outdated
Show resolved Hide resolved test/e2e/storage/testsuites/volumes.go Outdated
Show resolved Hide resolved test/e2e/storage/testsuites/volumes.go

@msau42 msau42 force-pushed the msau42:add-io-exec-test branch 2 times, most recently from b4d2df3 to 38e568f Nov 15, 2018

@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 15, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot added needs-rebase and removed do-not-merge/hold labels Nov 15, 2018

@msau42 msau42 force-pushed the msau42:add-io-exec-test branch from 38e568f to 39abfa3 Nov 19, 2018

@jsafrane

This comment has been minimized.

Sign in to view
Copy link
Member

jsafrane commented Nov 22, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot assigned jsafrane Nov 22, 2018

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 22, 2018

@davidz627

This comment has been minimized.

Sign in to view
Copy link
Contributor

davidz627 commented Nov 26, 2018

@AishSundar test addition only, would be good to add to v1.13

@msau42 msau42 referenced this pull request Nov 26, 2018

Merged

CSI topology e2e tests #70941

@fejta-bot

This comment has been minimized.

Sign in to view
Copy link

fejta-bot commented Nov 29, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.
1 similar comment
@fejta-bot

This comment has been minimized.

Sign in to view
Copy link

fejta-bot commented Nov 29, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.
@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 29, 2018

/lgtm cancel
I think I need to rebase

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 29, 2018

@msau42 msau42 force-pushed the msau42:add-io-exec-test branch from 39abfa3 to 03065a1 Nov 29, 2018

@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 29, 2018

Rebased and fixed the new v0 hostpath DriverInfo
@davidz627

This comment has been minimized.

Sign in to view
Copy link
Contributor

davidz627 commented Nov 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot assigned davidz627 Nov 29, 2018

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 29, 2018

@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 29, 2018

/test pull-kubernetes-node-e2e
@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 29, 2018

/test pull-kubernetes-integration
@davidz627

This comment has been minimized.

Sign in to view
Copy link
Contributor

davidz627 commented Nov 29, 2018

/retest
seems like this test: CSI Volumes [Driver: csi-hostpath] [Testpattern: Dynamic PV (default fs)] subPath should support existing directory 10m32s
flakes a lot, do we have an issue open for it?
@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 30, 2018

Opened #71578 for the flake
@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 30, 2018

/test pull-kubernetes-integration
@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 30, 2018

/retest
1 similar comment
@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 30, 2018

/retest
@fejta-bot

This comment has been minimized.

Sign in to view
Copy link

fejta-bot commented Nov 30, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.
1 similar comment
@fejta-bot

This comment has been minimized.

Sign in to view
Copy link

fejta-bot commented Nov 30, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.
@msau42

This comment has been minimized.

Sign in to view
Copy link
Member Author

msau42 commented Nov 30, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0955c93 into kubernetes:master Nov 30, 2018
17 of 18 checks passed

17 of 18 checks passed

pull-kubernetes-integration Job triggered.
Details
cla/linuxfoundation msau42 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@msau42 msau42 referenced this pull request Dec 4, 2018

Merged

Automated cherry pick of #70756: Add e2e test for file exec #71625: Volume exec file test: added NodeSelector to pod #71681

k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018

@k8s-ci-robot
Merge pull request #71681 from msau42/automated-cherry-pick-of-#70756-#… 
…71625-upstream-release-1.13

Automated cherry pick of #70756: Add e2e test for file exec #71625: Volume exec file test: added NodeSelector to pod
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c213003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment