New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addon-manager to 1.8.4 #70797

Merged
merged 1 commit into from Nov 9, 2018

Conversation

@mborsz
Copy link
Member

mborsz commented Nov 8, 2018

What type of PR is this?
/kind flake

What this PR does / why we need it:

Changes version of addon-manger to 1.8.4 which has a fix for an issue described here: #64022 (comment)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@mborsz mborsz force-pushed the mborsz:addon branch from be40159 to 2ca6334 Nov 9, 2018

@mborsz mborsz changed the title [WIP] Update addon-manager to 1.8.4 Update addon-manager to 1.8.4 Nov 9, 2018

@mborsz

This comment has been minimized.

Copy link
Member

mborsz commented Nov 9, 2018

/retest

@mborsz

This comment has been minimized.

Copy link
Member

mborsz commented Nov 9, 2018

/assign @kawych

@mborsz

This comment has been minimized.

Copy link
Member

mborsz commented Nov 9, 2018

This PR is to pickup changes introduced in kubernetes/autoscaler#1391.

The changes there are already released to the k8s.gcr.io repo with 1.8.4 label.

@mborsz

This comment has been minimized.

Copy link
Member

mborsz commented Nov 9, 2018

Karol is OOO today.
Solly, could you take a look?
/assign @DirectXMan12

@kawych

This comment has been minimized.

Copy link
Contributor

kawych commented Nov 9, 2018

I'm not OOO :) Maciej, I think there should be a corresponding release for Addon Resizer in the autoscaler repo. Looks like the last release is 1.8.1.

@kawych

This comment has been minimized.

Copy link
Contributor

kawych commented Nov 9, 2018

/lgtm
/approve
As discussed, the release is in progress.

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 9, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, mborsz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c8b3d0c into kubernetes:master Nov 9, 2018

18 checks passed

cla/linuxfoundation mborsz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment