New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreDNS should not tolerate master taints #70868

Merged
merged 1 commit into from Nov 16, 2018

Conversation

@justinsb
Copy link
Member

justinsb commented Nov 9, 2018

Otherwise users will be surprised when CoreDNS starts running on their
masters, where kube-dns did not.

Issue #70851

/kind bug

For kube-up and derived configurations, CoreDNS will honor master taints, for consistency with kube-dns behavior.
CoreDNS should respect user taints
Otherwise users will be surprised when CoreDNS starts running on their
masters, where kube-dns did not.

Issue #70851

@k8s-ci-robot k8s-ci-robot requested review from bowei and MrHohn Nov 9, 2018

@justinsb justinsb changed the title CoreDNS should respect user taints CoreDNS should respect master taints Nov 9, 2018

@justinsb justinsb changed the title CoreDNS should respect master taints CoreDNS should not tolerate master taints Nov 9, 2018

@MrHohn

This comment has been minimized.

Copy link
Member

MrHohn commented Nov 9, 2018

@MrHohn

This comment has been minimized.

Copy link
Member

MrHohn commented Nov 9, 2018

xref #54945

@MrHohn

This comment has been minimized.

Copy link
Member

MrHohn commented Nov 9, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rajansandeep
Copy link
Member

rajansandeep left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 9, 2018

@rajansandeep

This comment has been minimized.

Copy link
Member

rajansandeep commented Nov 9, 2018

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Nov 9, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Nov 10, 2018

Can we triage into milestone 1.13 - not sure who should make that call - @roberthbailey or @thockin ?

I think there might actually be a case for only running on the master (as proposed in #54945), once we have the DNS node-local agent that @prameshj is working on in #70555. But the node-local agent needs time to bake before we make that decision, IMO.

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Nov 15, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 15, 2018

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Nov 16, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 29eb75b into kubernetes:master Nov 16, 2018

18 checks passed

cla/linuxfoundation justinsb authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment